From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id C92F71FF16B for ; Tue, 26 Aug 2025 16:58:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6BAEA36CD3; Tue, 26 Aug 2025 16:58:43 +0200 (CEST) From: Shannon Sterz To: pve-devel@lists.proxmox.com Date: Tue, 26 Aug 2025 16:58:28 +0200 Message-ID: <20250826145836.302748-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250826145836.302748-1-s.sterz@proxmox.com> References: <20250826145836.302748-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1756220313519 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [icon-sdn.dot, wikimedia.org] Subject: [pve-devel] [PATCH manager 1/9] fix #6599: ui: use font-awesome hdd icon instead of png X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" previously we used custom png rendered for storages in the add menu of a pool, as well as for mountpoints of containers. these appeared blurry on high resolution displays and since they were just the same as the font-awesome icons anyway, use those directly. the ui already loads font-awesome regardless, so there are no down-sides here. Signed-off-by: Shannon Sterz --- www/css/ext6-pve.css | 7 ------- www/images/Makefile | 8 +++----- www/images/icon-harddisk.png | Bin 293 -> 0 bytes www/manager6/grid/PoolMembers.js | 2 +- www/manager6/lxc/Resources.js | 2 +- 5 files changed, 5 insertions(+), 14 deletions(-) delete mode 100644 www/images/icon-harddisk.png diff --git a/www/css/ext6-pve.css b/www/css/ext6-pve.css index 192c82088..356427ead 100644 --- a/www/css/ext6-pve.css +++ b/www/css/ext6-pve.css @@ -313,7 +313,6 @@ .pve-itype-icon-swap, .pve-itype-icon-node, .pve-itype-icon-node-running, -.pve-itype-icon-storage, .pve-itype-icon-pool, .pve-itype-icon-itype, .pve-itype-icon-usb, @@ -366,12 +365,6 @@ background-image: url(../images/lxc-on.png); } -.pve-itype-icon-storage, -.x-tree-node-harddisk, -.x-grid-tree-node-expanded .x-tree-node-harddisk { - background-image: url(../images/icon-harddisk.png); -} - .x-tree-node-snapshot, .x-grid-tree-node-expanded .x-tree-node-snapshot { background-image: url(../images/snapshot.png); diff --git a/www/images/Makefile b/www/images/Makefile index ad39c8c50..8072d0292 100644 --- a/www/images/Makefile +++ b/www/images/Makefile @@ -16,9 +16,8 @@ all: # icon-cd, icon-pci # are self made (sources as .xcf) -# icon-swap, icon-display, icon-harddisk, icon-keyboard, icon-network, icon-usb, icon-cloud -# come from fontawesome (respective fa-refresh, fa-desktop, fa-hdd-o, fa-keyboard-o, fa-exchange, fa-usb, fa-ellipsis-h, fa-cloud) - +# icon-swap, icon-display, icon-keyboard, icon-network, icon-usb, icon-cloud +# come from fontawesome (respective fa-refresh, fa-desktop, fa-keyboard-o, fa-exchange, fa-usb, fa-ellipsis-h, fa-cloud) # icon-serial is a modified version of # https://commons.wikimedia.org/wiki/File:DE9_Diagram.svg # (public domain) @@ -69,7 +68,6 @@ IMAGES = $(GNOME_IMAGES) \ icon-cd.png \ icon-network.png \ icon-display.png \ - icon-harddisk.png \ icon-keyboard.png \ logo-ceph.png \ logo-128.png \ @@ -88,7 +86,7 @@ IMAGES = $(GNOME_IMAGES) \ icon-sdn.svg: icon-sdn.dot fdp -Tsvg $< > $@ -.PHONY: install +.PHONY: install install: $(IMAGES) install -d $(WWWIMAGEDIR) install -m 0644 $(IMAGES) $(WWWIMAGEDIR) diff --git a/www/images/icon-harddisk.png b/www/images/icon-harddisk.png deleted file mode 100644 index 38faeb94538fb340a424c6c596a129979e80eccf..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 293 zcmeAS@N?(olHy`uVBq!ia0vp^0wB!61|;P_|4#%`Y)RhkE)4%caKYZ?lYt_)JY5_^ zEP9V#vh{Kf6kvVeKUtMy+ao?94hhdqoZ1J~xKFUHY0WusPi?6}#Em7siY*hYTJ2e+ zwH-Y&CmpIb+*$elqs|fL;5$Dpi_@Ncx_`s_-tUZu2I~K1m30;`o~07AsQbB0Q}Ue$ zTK;Ec)LFY`S8#ik7f3a|jEMA|b#dd#lD6nITpVFLxOZAtIPG3wv8Z`^NT%+F|Hrca z#4PM%kC_s{&>UdgYrP_&v7hJn5f=6x{By+@s{NMX+*k1Kcm9_TJ0yFQ&s;dZ;R#1+ p%;vo(+4{VM_9Vp^eed7M=5^R`=0u)L*MPoc@O1TaS?83{1OP#OcliJS diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js index f025a1380..c6e7e9175 100644 --- a/www/manager6/grid/PoolMembers.js +++ b/www/manager6/grid/PoolMembers.js @@ -252,7 +252,7 @@ Ext.define('PVE.grid.PoolMembers', { }, { text: gettext('Storage'), - iconCls: 'pve-itype-icon-storage', + iconCls: 'fa fa-hdd-o', handler: function () { var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool }); win.on('destroy', reload); diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js index 9f6df3a58..3defb8003 100644 --- a/www/manager6/lxc/Resources.js +++ b/www/manager6/lxc/Resources.js @@ -128,7 +128,7 @@ Ext.define('PVE.lxc.RessourceView', { rows[confid] = { group: group, order: i, - tdCls: 'pve-itype-icon-storage', + iconCls: 'hdd-o', editor: mpeditor, header: header, renderer: Ext.htmlEncode, -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel