From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EBF3D1FF16F for ; Tue, 19 Aug 2025 15:18:24 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1321E15ADC; Tue, 19 Aug 2025 15:19:55 +0200 (CEST) From: Gabriel Goller To: pve-devel@lists.proxmox.com Date: Tue, 19 Aug 2025 15:19:03 +0200 Message-ID: <20250819131916.324392-5-g.goller@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250819131916.324392-1-g.goller@proxmox.com> References: <20250819131916.324392-1-g.goller@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755609518229 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fabrics.rs] Subject: [pve-devel] [PATCH proxmox-perl-rs 1/1] pve-rs: fabrics: add IS-IS protocol ifupdown config generation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Generate the interfaces that have been configured with IS-IS to the ifupdown config (enable ip-forwarding on all). IS-IS needs to have the ip-address duplicated from the dummy interface to every interface in unnumbered mode (like with ospf). This could potentially be fixed in the future with [0]. [0]: https://github.com/FRRouting/frr/pull/19429 Signed-off-by: Gabriel Goller --- pve-rs/src/bindings/sdn/fabrics.rs | 57 +++++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/pve-rs/src/bindings/sdn/fabrics.rs b/pve-rs/src/bindings/sdn/fabrics.rs index 587b1d68c8fb..d345112de4f3 100644 --- a/pve-rs/src/bindings/sdn/fabrics.rs +++ b/pve-rs/src/bindings/sdn/fabrics.rs @@ -348,7 +348,14 @@ pub mod pve_rs_sdn_fabrics { match node { ConfigNode::Openfabric(node_section) => { for interface in node_section.properties_mut().interfaces_mut() { - if let Some(mapped_name) = map_name(&mapping, &interface.name())? { + if let Some(mapped_name) = map_name(&mapping, interface.name())? { + interface.set_name(mapped_name); + } + } + } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties_mut().interfaces_mut() { + if let Some(mapped_name) = map_name(&mapping, interface.name())? { interface.set_name(mapped_name); } } @@ -452,6 +459,9 @@ pub mod pve_rs_sdn_fabrics { FabricEntry::Openfabric(_) => { daemons.insert("fabricd"); } + FabricEntry::Isis(_) => { + daemons.insert("isisd"); + } }; } @@ -553,6 +563,51 @@ pub mod pve_rs_sdn_fabrics { } } } + ConfigNode::Isis(node_section) => { + for interface in node_section.properties().interfaces() { + if interface.ip().is_some() || interface.ip6().is_some() { + if let Some(ip) = interface.ip() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + if let Some(ip) = interface.ip6() { + let interface = + render_interface(interface.name(), Cidr::from(ip), false)?; + writeln!(interfaces)?; + write!(interfaces, "{interface}")?; + } + } else { + let interface_string: String; + if let Some(ip) = node.ip() { + interface_string = render_interface( + interface.name(), + Cidr::from(IpAddr::from(ip)), + false, + )?; + } else if let Some(ip6) = node.ip6() { + interface_string = render_interface( + interface.name(), + Cidr::from(IpAddr::from(ip6)), + false, + )?; + } else { + return Err(anyhow::anyhow!("there has to be a ipv4 address")); + } + writeln!(interfaces)?; + write!(interfaces, "{interface_string}")?; + } + + // If not ip is configured, add auto and empty iface to bring interface up + if let (None, None) = (interface.ip(), interface.ip6()) { + writeln!(interfaces)?; + writeln!(interfaces, "auto {}", interface.name())?; + writeln!(interfaces, "iface {}", interface.name())?; + writeln!(interfaces, "\tip-forward 1")?; + } + } + } ConfigNode::Ospf(node_section) => { for interface in node_section.properties().interfaces() { if let Some(ip) = interface.ip() { -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel