From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ADBD11FF185 for ; Mon, 18 Aug 2025 12:00:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 94ED134862; Mon, 18 Aug 2025 12:01:52 +0200 (CEST) From: Shan Shaji To: pve-devel@lists.proxmox.com Date: Mon, 18 Aug 2025 12:01:32 +0200 Message-ID: <20250818100134.30550-2-s.shaji@proxmox.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250818100134.30550-1-s.shaji@proxmox.com> References: <20250818100134.30550-1-s.shaji@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755511270078 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.188 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH pve_flutter_frontend v5 1/3] ui: ios: enable noVNC console support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The noVNC console was disabled in iOS and was only available in android To fix the issue, add additional platform check for iOS and enabled the noVNC console option. Signed-off-by: Shan Shaji --- lib/widgets/pve_console_menu_widget.dart | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/widgets/pve_console_menu_widget.dart b/lib/widgets/pve_console_menu_widget.dart index 473595d..6de2c0b 100644 --- a/lib/widgets/pve_console_menu_widget.dart +++ b/lib/widgets/pve_console_menu_widget.dart @@ -97,7 +97,7 @@ class PveConsoleMenu extends StatelessWidget { } }, ), - if (Platform.isAndroid) // web_view is only available for mobile :( + if (Platform.isAndroid || Platform.isIOS) // web_view is only available for mobile :( ListTile( title: const Text( //type == "qemu" ? "noVNC Console" : "xterm.js Console", @@ -106,7 +106,6 @@ class PveConsoleMenu extends StatelessWidget { ), subtitle: const Text("Open console view"), onTap: () async { - if (Platform.isAndroid) { if (['qemu', 'lxc'].contains(type)) { SystemChrome.setEnabledSystemUIMode( SystemUiMode.immersive); @@ -134,9 +133,6 @@ class PveConsoleMenu extends StatelessWidget { ]); }); } - } else { - print('not implemented for current platform'); - } }, ), ], -- 2.50.1 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel