From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 687B91FF165 for ; Thu, 14 Aug 2025 14:40:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 90FCD11E33; Thu, 14 Aug 2025 14:41:41 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Thu, 14 Aug 2025 14:40:59 +0200 Message-Id: <20250814124059.2793662-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755175234450 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH kernel-helper] proxmox-boot: unconditionally mask systemd-gpt-auto-generator X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The efi.mount and efi.automount units created by this generator if: * the ESP has the partition-type-uuid set to the ESP one * the system uses a boot-loader that sets the LoaderUUID efivar (systemd-boot and grub without secure-boot enabled) * does not have the ESP mounted by default cause the ESP to be mounted at /efi, which in turn cause issues when systemd-boot (metapackage) is installed/updated - as it autoinstalls itself at /efi, but does not create the loader-entries for the kernel, since we disabled /etc/kernel/postinst.d/zz-systemd-boot Simply mask the generator, as its functionality is not needed on any regular Proxmox system. Signed-off-by: Stoiko Ivanov --- Tested on a VM where I reproduced the setup above. This is also why I used the all-caps: MASKING in the output - as it's easy to overlook in the large number of lines that are printed. src/proxmox-boot/zz-proxmox-boot | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/proxmox-boot/zz-proxmox-boot b/src/proxmox-boot/zz-proxmox-boot index ad6620a..7847777 100755 --- a/src/proxmox-boot/zz-proxmox-boot +++ b/src/proxmox-boot/zz-proxmox-boot @@ -271,6 +271,18 @@ check_grub_efi_removable_status() { echo "" } +mask_sd_gpt_generator() { + generator="systemd-gpt-auto-generator" + mask_dir="/etc/systemd/system-generators" + # already masked (or re-enabled manually) - nothing to do: + if [ -e "$mask_dir/$generator" ]; then + return + fi + warn "$generator causes problems in certain configurations - MASKING it!" + mkdir -p "$mask_dir" + ln -s /dev/null "$mask_dir/$generator" +} + set -- $DEB_MAINT_PARAMS mode="${1#\'}" mode="${mode%\'}" @@ -286,6 +298,7 @@ case $0:$mode in disable_systemd_boot_hook check_grub_efi_package check_grub_efi_removable_status + mask_sd_gpt_generator ;; */postrm.d/*:|*/postrm.d/*:remove) reexec_in_mountns "$@" @@ -295,6 +308,7 @@ case $0:$mode in disable_systemd_boot_hook check_grub_efi_package check_grub_efi_removable_status + mask_sd_gpt_generator ;; esac -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel