From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 49DCC1FF165 for ; Thu, 14 Aug 2025 02:12:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3891A3DFEF; Thu, 14 Aug 2025 02:14:07 +0200 (CEST) Date: Thu, 14 Aug 2025 02:13:35 +0200 From: Stoiko Ivanov To: Maximiliano Sandoval Message-ID: <20250814021335.600acfe1@rosa.proxmox.com> In-Reply-To: <20250404131438.328396-8-m.sandoval@proxmox.com> References: <20250404131438.328396-1-m.sandoval@proxmox.com> <20250404131438.328396-8-m.sandoval@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755130382675 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.065 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pmg-devel] [PATCH pmg-api v5 08/11] mailqueue: make mail queue writable by pmg group X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmg-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" On Fri, 4 Apr 2025 15:14:35 +0200 Maximiliano Sandoval wrote: > Signed-off-by: Maximiliano Sandoval > --- > debian/postinst | 9 +++++++++ > src/PMG/MailQueue.pm | 7 ++++--- > 2 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/debian/postinst b/debian/postinst > index c12870fa..ba6497a0 100644 > --- a/debian/postinst > +++ b/debian/postinst > @@ -53,6 +53,15 @@ migrate_pmg_smtp_filter() { > > chown :pmg /var/lib/pmg > > + chown :pmg /var/spool/pmg/active > + chown :pmg /var/spool/pmg/virus > + chown :pmg /var/spool/pmg/spam > + chown :pmg /var/spool/pmg/attachment > + chmod g+w /var/spool/pmg/active > + chmod g+w /var/spool/pmg/virus > + chmod g+w /var/spool/pmg/spam > + chmod g+w /var/spool/pmg/attachment > + I think this would be a bit more readable as a loop over `active virus spam attachment`. > if systemctl --quiet is-active rrdcached.service ; then > systemctl daemon-reload > deb-systemd-invoke reload-or-try-restart rrdcached.service >/dev/null || true > diff --git a/src/PMG/MailQueue.pm b/src/PMG/MailQueue.pm > index 4e37cb98..adbf28c1 100644 > --- a/src/PMG/MailQueue.pm > +++ b/src/PMG/MailQueue.pm > @@ -33,12 +33,13 @@ sub create_spooldirs { > "$spooldir/attachment", > ]) if $cleanup; > > - mkpath([ > + mkpath( > "$spooldir/active", > "$spooldir/spam", > "$spooldir/virus", > "$spooldir/attachment", > - ]); > + { group=>'pmg', chmod=>0775 }, > + ); > > if ($lcid) { > mkpath "$spooldir/cluster/$lcid/virus"; > @@ -68,7 +69,7 @@ sub new_fileid { > my $uid; > my $subsubdir = ''; > > - if (!($fh = IO::File->new ($path, 'w+', 0600))) { > + if (!($fh = IO::File->new ($path, 'w+', 0660))) { > die "unable to create file '$path': $! : ERROR"; > } > _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel