From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 0877C1FF183 for ; Wed, 13 Aug 2025 13:02:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D4B9A316B9; Wed, 13 Aug 2025 13:04:02 +0200 (CEST) From: Maximiliano Sandoval To: pbs-devel@lists.proxmox.com Date: Wed, 13 Aug 2025 13:03:27 +0200 Message-ID: <20250813110328.330900-3-m.sandoval@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250813110328.330900-1-m.sandoval@proxmox.com> References: <20250813110328.330900-1-m.sandoval@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755082976983 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.093 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 3/3] time: Add more calendat event tests X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Signed-off-by: Maximiliano Sandoval --- proxmox-time/src/calendar_event.rs | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/proxmox-time/src/calendar_event.rs b/proxmox-time/src/calendar_event.rs index edb258ba..8222bcec 100644 --- a/proxmox-time/src/calendar_event.rs +++ b/proxmox-time/src/calendar_event.rs @@ -477,8 +477,14 @@ mod tests { use std::str::FromStr; assert!(CalendarEvent::from_str("15:30").is_ok()); + assert!(CalendarEvent::from_str("0").is_ok()); + assert!(CalendarEvent::from_str("59").is_ok()); + assert!(CalendarEvent::from_str("15:30:59").is_ok()); assert!(CalendarEvent::from_str("40:00").is_err()); + assert!(CalendarEvent::from_str("60").is_err()); + assert!(CalendarEvent::from_str("24:61").is_err()); + assert!(CalendarEvent::from_str("15:30:60").is_err()); } #[test] @@ -494,6 +500,10 @@ mod tests { } ); + assert!(parse_time_spec("1:00:00").is_ok()); + assert!(parse_time_spec("1:00").is_ok()); + assert!(parse_time_spec("59").is_ok()); + // These do not strictly fail, but should fail when parsed with FromStr // since there will be input left to consume. let (input, data) = parse_time_spec("40:00").unwrap(); @@ -506,5 +516,23 @@ mod tests { second: vec![DateTimeValue::Single(0)] } ); + + assert!(parse_time_spec("61").is_err()); + // This should be 1:00 instead. + assert!(parse_time_spec("60").is_err()); + + // Can only partially parse + let (input, _data) = parse_time_spec("24:61").unwrap(); + assert_eq!(input, ":61"); + + + assert_eq!( + data, + TimeSpec { + hour: vec![], + minute: vec![DateTimeValue::Single(40)], + second: vec![DateTimeValue::Single(0)] + } + ); } } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel