From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 21DBB1FF16B for ; Tue, 12 Aug 2025 16:37:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 02E9F102F2; Tue, 12 Aug 2025 16:39:09 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 12 Aug 2025 16:37:43 +0200 Message-ID: <20250812143900.138723-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250812143900.138723-1-f.ebner@proxmox.com> References: <20250812143900.138723-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755009513491 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server v2 5/5] cfg2cmd: add reminder comments to remove template handling for -drive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Signed-off-by: Fiona Ebner --- src/PVE/QemuServer.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index aacdadad..d40b14de 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -3778,6 +3778,9 @@ sub config_to_command { print_drive_commandline_full($storecfg, $vmid, $drive, $live_blockdev_name); if ($is_template) { + # TODO PVE 10.x - since the temporary config for starting templates for backup + # uses the latest machine version, this should already be dead code. It's kept + # for now if for whatever reason an older QEMU build is used (e.g. bisecting). my $interface = $drive->{interface}; $drive_cmd .= ',readonly=on' if $interface ne 'ide' && $interface ne 'sata'; } @@ -3910,6 +3913,10 @@ sub config_to_command { } if ($is_template) { + # TODO PVE 10.x - since the temporary config for starting templates for backup uses the + # latest machine version, this should already be dead code. It's kept for now if for + # whatever reason an older QEMU build is used (e.g. bisecting). + # needed to workaround base volumes being read-only push @$cmd, '-snapshot'; } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel