From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DFD8B1FF16B for ; Tue, 12 Aug 2025 16:37:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2898F1025B; Tue, 12 Aug 2025 16:39:08 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 12 Aug 2025 16:37:38 +0200 Message-ID: <20250812143900.138723-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1755009513463 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm, drive.pm, ovmf.pm] Subject: [pve-devel] [PATCH-SERIES qemu-server v2 0/5] fix #6675: template backup: fix regression with IDE/SATA and blockdev X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes in v2: * new approach, attach as ide-cd rather than using older machine version, which would break qcow2 snapshot-as-volume-chain * get rid of now outdated drive_is_read_only() helper With ide-hd, the inserted block node needs to be marked as writable too, but -blockdev will complain if it's marked as writable but the actual backing device is read-only (e.g. read-only base LV). IDE/SATA do not support being configured as read-only, the most similar is using ide-cd instead of ide-hd, with most of the code and configuration shared in QEMU. Since a template is never actually started, the front-end device is never accessed. The backup only accesses the inserted block node, so it does not matter for the backup if the type is 'ide-cd' instead. The same issue did not manifest for '-drive', because the '-snapshot' option is used for template backups. The '-snapshot' option does not affect '-blockdev', from 'man kvm': > snapshot is incompatible with -blockdev Fiona Ebner (5): ovmf: pass along whether the VM is a template code cleanup: cfg2cmd: check if configuration is for template centrally fix #6675: template backup: fix regression with IDE/SATA and blockdev code cleanup: drive: get rid of outdated drive_is_read_only() helper cfg2cmd: add reminder comments to remove template handling for -drive src/PVE/QemuServer.pm | 37 ++++++++++++++++------ src/PVE/QemuServer/Drive.pm | 10 ------ src/PVE/QemuServer/OVMF.pm | 20 ++++++------ src/test/cfg2cmd/simple1-template.conf.cmd | 4 +-- 4 files changed, 39 insertions(+), 32 deletions(-) -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel