From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8767B1FF16B for ; Tue, 12 Aug 2025 10:26:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 602A6CEA6; Tue, 12 Aug 2025 10:28:31 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Tue, 12 Aug 2025 10:28:14 +0200 Message-ID: <20250812082824.30625-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754987277643 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: storage edit: warn about disabling snapshot-as-volume-chain on LVM X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Existing qcow2 volumes on a storage won't be handled correctly anymore after the setting is turned off. The setting is already a fixed storage setting for directory-based storages, so this is only relevant for LVM. Could be improved by checking in the backend if there are any qcow2 images and only allow turning it off if not, but this requires changes to the on_update_hook() signature. Until then, warn in the front-end. Signed-off-by: Fiona Ebner --- Went with a warning rather than disallowing, so that the limitation gets visibly communicated to the user. www/manager6/storage/Base.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/www/manager6/storage/Base.js b/www/manager6/storage/Base.js index 84c08f2c..cf89ef6d 100644 --- a/www/manager6/storage/Base.js +++ b/www/manager6/storage/Base.js @@ -90,6 +90,14 @@ Ext.define('PVE.panel.StorageBase', { }); me.advancedColumnB = me.advancedColumnB || []; + if (me.type === 'lvm') { + me.advancedColumnB.unshift({ + xtype: 'displayfield', + name: 'external-snapshot-hint-lvm', + userCls: 'pmx-hint', + value: gettext('Keep Snapshots as Volume-Chain enabled if qcow2 images exist!'), + }); + } me.advancedColumnB.unshift({ xtype: 'displayfield', name: 'external-snapshot-hint', -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel