From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id B5DF51FF187 for ; Mon, 11 Aug 2025 16:17:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BA5D37AF0; Mon, 11 Aug 2025 16:18:50 +0200 (CEST) From: Stefan Hanreich To: pdm-devel@lists.proxmox.com Date: Mon, 11 Aug 2025 16:18:43 +0200 Message-ID: <20250811141847.271476-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250811141847.271476-1-s.hanreich@proxmox.com> References: <20250811141847.271476-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pdm-devel] [PATCH proxmox-datacenter-manager 2/3] api: privileged: fix fchownat call X-BeenThere: pdm-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Datacenter Manager development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pdm-devel-bounces@lists.proxmox.com Sender: "pdm-devel" When starting the privileged API, the server would fail with the following error messages: Error: unable to set ownership for api socket '/run/proxmox-datacenter-manager/priv.sock' - EINVAL: Invalid argument chown(2) only supports the AT_SYMLINK_NOFOLLOW, not AT_SYMLINK_FOLLOW so this was probably a oversight. Pass empty flags to fchownat instead. Signed-off-by: Stefan Hanreich --- server/src/bin/proxmox-datacenter-privileged-api.rs | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/server/src/bin/proxmox-datacenter-privileged-api.rs b/server/src/bin/proxmox-datacenter-privileged-api.rs index 66033eb..bd2c6dd 100644 --- a/server/src/bin/proxmox-datacenter-privileged-api.rs +++ b/server/src/bin/proxmox-datacenter-privileged-api.rs @@ -161,16 +161,9 @@ async fn run() -> Result<(), Error> { format_err!("unable to set mode for api socket '{sockpath:?}' - {err}") })?; - fchownat( - None, - sockpath, - None, - Some(api_user.gid), - AtFlags::AT_SYMLINK_FOLLOW, - ) - .map_err(|err| { - format_err!("unable to set ownership for api socket '{sockpath}' - {err}") - })?; + fchownat(None, sockpath, None, Some(api_user.gid), AtFlags::empty()).map_err( + |err| format_err!("unable to set ownership for api socket '{sockpath}' - {err}"), + )?; log::info!("created socket, notifying readiness to systemd and starting API server"); -- 2.47.2 _______________________________________________ pdm-devel mailing list pdm-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel