From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B94DB1FF15C for ; Fri, 8 Aug 2025 16:15:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BD6D199A3; Fri, 8 Aug 2025 16:17:18 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com Date: Fri, 8 Aug 2025 16:16:33 +0200 Message-ID: <20250808141633.96960-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754662581458 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.025 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [rrd.pm] Subject: [pve-devel] [PATCH pve-cluster] fix #6615: rrd: only return populated entries X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" RRD fetch can include the latest bucket before metrics are flushed, resulting in entries with only a timestamp. This now only returns entries with at least one value. Signed-off-by: Hannes Laimer --- src/PVE/RRD.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/PVE/RRD.pm b/src/PVE/RRD.pm index 8fe1927..41737ee 100644 --- a/src/PVE/RRD.pm +++ b/src/PVE/RRD.pm @@ -67,10 +67,12 @@ sub create_rrd_data { for my $line (@$data) { my $entry = { 'time' => $start }; $start += $step; + my $has_value = 0; for (my $i = 0; $i < $fields; $i++) { my $name = $names->[$i]; if (defined(my $val = $line->[$i])) { $entry->{$name} = $val; + $has_value = 1 if !$has_value; $entry->{memavailable} = $val if $is_node && $name eq 'memfree' && !exists($entry->{memavailable}); } else { @@ -78,7 +80,8 @@ sub create_rrd_data { # maybe make this configurable? } } - push @$res, $entry; + # Do not return entries that only contain 'time' without any metric values + push @$res, $entry if $has_value; } return $res; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel