From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5D9C91FF189 for ; Fri, 8 Aug 2025 13:40:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ADD3D15F26; Fri, 8 Aug 2025 13:42:00 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Fri, 8 Aug 2025 13:41:17 +0200 Message-ID: <20250808114117.393536-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250808114117.393536-1-c.ebner@proxmox.com> References: <20250808114117.393536-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754653263162 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ietf.org, timestamps.rs] Subject: [pbs-devel] [PATCH proxmox 2/2] s3-client: add regression tests for http date header parsing X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Basic tests to check that the header is parsed as expected if present and ignored if not. Signed-off-by: Christian Ebner --- proxmox-s3-client/src/response_reader.rs | 24 ++++++++++++++++++++++++ proxmox-s3-client/src/timestamps.rs | 2 +- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/proxmox-s3-client/src/response_reader.rs b/proxmox-s3-client/src/response_reader.rs index f200e15a..c00c7bd4 100644 --- a/proxmox-s3-client/src/response_reader.rs +++ b/proxmox-s3-client/src/response_reader.rs @@ -632,3 +632,27 @@ fn parse_list_buckets_response_test() { ] ); } + +#[test] +fn test_optional_date_header_parsing() { + let mut header_map = HeaderMap::new(); + + let expected_date = "Wed, 12 Oct 2009 17:50:00 GMT"; + header_map.insert(header::DATE, expected_date.parse().unwrap()); + let parsed_date = ResponseReader::parse_optional_date_header(&header_map).unwrap(); + assert!(parsed_date.is_some()); + assert_eq!( + parsed_date.unwrap(), + HttpDate::from_str(expected_date).unwrap(), + ); + + header_map.clear(); + let invalid_date_format = "2019-11-10"; + header_map.insert(header::DATE, invalid_date_format.parse().unwrap()); + assert!(ResponseReader::parse_optional_date_header(&header_map).is_err()); + + header_map.clear(); + assert!(ResponseReader::parse_optional_date_header(&header_map) + .unwrap() + .is_none()); +} diff --git a/proxmox-s3-client/src/timestamps.rs b/proxmox-s3-client/src/timestamps.rs index 661e1fdf..74397593 100644 --- a/proxmox-s3-client/src/timestamps.rs +++ b/proxmox-s3-client/src/timestamps.rs @@ -28,7 +28,7 @@ serde_plain::derive_deserialize_from_fromstr!(LastModifiedTimestamp, "last modif /// https://datatracker.ietf.org/doc/html/rfc2616#section-3.3 /// https://datatracker.ietf.org/doc/html/rfc1123#section-5.2.14 /// https://datatracker.ietf.org/doc/html/rfc822#section-5 -#[derive(Debug)] +#[derive(Debug, PartialEq)] pub struct HttpDate { _epoch: i64, } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel