From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B34921FF170 for ; Thu, 7 Aug 2025 22:31:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A01FD37534; Thu, 7 Aug 2025 22:32:34 +0200 (CEST) Date: Thu, 7 Aug 2025 22:31:59 +0200 From: Stoiko Ivanov To: Fiona Ebner Message-ID: <20250807223159.6722e37e@rosa.proxmox.com> In-Reply-To: <86af5762-5b31-4000-8180-5ea64103b442@proxmox.com> References: <20250806110251.2117322-1-s.ivanov@proxmox.com> <86af5762-5b31-4000-8180-5ea64103b442@proxmox.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754598696641 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] superseded: [PATCH manager v2] 8 to 9 checks: do not ask bootctl if systemd-boot is used. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Thanks big-time for the feedback on- and off-list! sent an updated v3: https://lore.proxmox.com/pve-devel/20250807203004.336616-1-s.ivanov@proxmox.com/T/#t On Thu, 7 Aug 2025 14:29:34 +0200 Fiona Ebner wrote: > Am 06.08.25 um 1:03 PM schrieb Stoiko Ivanov: > > get systemd-boot installed to /boot/efi upon upgrade > > What problems does this cause (except for the false positive)? Can/do > users need to do something to recover? If yes, I think we should have > the script output more information. > > > @@ -1624,18 +1624,11 @@ sub check_bootloader { > > } > > } else { > > if (-f "/usr/share/doc/systemd-boot/changelog.Debian.gz") { > > - my $exit_code = eval { > > - run_command(['bootctl', 'is-installed', '--quiet', '--graceful'], noerr => 1); > > - }; > > - if ($exit_code != 0) { > > - log_warn( > > - "systemd-boot meta-package installed but the system does not seem to use it" > > - . " for booting. This can cause problems on upgrades of other boot-related packages." > > - . " Consider removing 'systemd-boot'"); > > - } else { > > - log_info("systemd-boot used as bootloader and fitting meta-package installed."); > > - return; > > - } > > + log_warn( > > + "systemd-boot meta-package installed. This can cause problems on upgrades of other" > > + ." boot-related packages. Unless you manually setup the system to use" > > + ." systemd-boot remove 'systemd-boot'"); > > + return; > > Note that we did not return in the 'if' branch previously, which means > the next check below won't be done anymore. Is that intentional? It > seems like it should be done. > > > } > > if (!-f "/usr/share/doc/grub-efi-amd64/changelog.Debian.gz") { > > log_warn("System booted in uefi mode but grub-efi-amd64 meta-package not installed," > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel