From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 142C81FF17C for ; Wed, 6 Aug 2025 16:30:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D232B3CED4; Wed, 6 Aug 2025 16:32:16 +0200 (CEST) From: Stefan Hanreich To: pbs-devel@lists.proxmox.com Date: Wed, 6 Aug 2025 16:29:22 +0200 Message-ID: <20250806142927.344007-2-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250806142927.344007-1-s.hanreich@proxmox.com> References: <20250806142927.344007-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.192 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [helper.rs] Subject: [pbs-devel] [PATCH proxmox 1/1] network-api: make address field optional X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Certain network interfaces do not have a MAC address, for instance tailscale is layer-3 only, therefore the interfaces do not have a MAC address. Make the address field optional to prevent the network interface parsing logic from throwing an error in such cases. Signed-off-by: Stefan Hanreich --- proxmox-network-api/src/config/helper.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/proxmox-network-api/src/config/helper.rs b/proxmox-network-api/src/config/helper.rs index 4f17b9ee..ca80d47f 100644 --- a/proxmox-network-api/src/config/helper.rs +++ b/proxmox-network-api/src/config/helper.rs @@ -137,7 +137,7 @@ pub struct IpLink { altnames: Vec, ifindex: i64, link_type: String, - address: MacAddress, + address: Option, linkinfo: Option, operstate: String, } @@ -157,12 +157,10 @@ impl IpLink { &self.ifname } - pub fn permanent_mac(&self) -> MacAddress { + pub fn permanent_mac(&self) -> Option { if let Some(link_info) = &self.linkinfo { if let Some(info_slave_data) = &link_info.info_slave_data { - if let Some(perm_hw_addr) = info_slave_data.perm_hw_addr { - return perm_hw_addr; - } + return info_slave_data.perm_hw_addr; } } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel