From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 578871FF17C for ; Wed, 6 Aug 2025 11:56:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E97C437C85; Wed, 6 Aug 2025 11:57:37 +0200 (CEST) From: Shannon Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 6 Aug 2025 11:57:02 +0200 Message-ID: <20250806095702.135277-3-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250806095702.135277-1-s.sterz@proxmox.com> References: <20250806095702.135277-1-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754474204108 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/1] ui: login: opt the tfa challenge handling into the new HttpOnly flow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this was missed previously leading to the tfa part of the auth flow not opting into the new auth flow. this meant the server did not add a Set-Cookie header. after that whether or not a login worked fine became a race between the refresh logic (which was opted into the new flow and, thus, would yield a proper HttpOnly cookie) and other requests. Signed-off-by: Shannon Sterz --- www/LoginView.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/www/LoginView.js b/www/LoginView.js index 9c1ac38a..cf6c2cf7 100644 --- a/www/LoginView.js +++ b/www/LoginView.js @@ -114,6 +114,7 @@ Ext.define('PBS.LoginView', { let userid = data.username; let ticket = data.ticket; + let http_only = true; let challenge = JSON.parse( decodeURIComponent(ticket.split(':')[1].slice('!tfa!'.length)), ); @@ -123,6 +124,7 @@ Ext.define('PBS.LoginView', { userid, ticket, challenge, + http_only, onResolve: (value) => resolve(value), onReject: reject, }).show(); -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel