From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 366EB1FF16F for ; Tue, 5 Aug 2025 23:39:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A7DC1E11B; Tue, 5 Aug 2025 23:40:47 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 5 Aug 2025 23:40:06 +0200 Message-Id: <20250805214006.1111543-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754429993454 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC installer] install: do not create deprecated /etc/timezone X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" starting with tzdata version 2024b-5 [0] the package does not create /etc/timezone anymore (background is quite well explained in /usr/share/doc/tzdata/NEWS.Debian.gz: ``` Previously, the tzdata package in Debian used the /etc/timezone file to configure the system's timezone. This method is not supported by systemd and certain desktop environments, which instead only change the /etc/localtime symlink to point to a file in /usr/share/zoneinfo. .... In a future release, the /etc/timezone file will be automatically removed ... The debian-installer from Trixie also no longer creates this file. ``` align our installer with debian's installer. [0] https://metadata.ftp-master.debian.org/changelogs//main/t/tzdata/tzdata_2025b-4_changelog Signed-off-by: Stoiko Ivanov --- I would NOT recommend adding this patch now - we'd need to check where our code relies on /etc/timezone being present (PVE/INotify.pm creates it IIRC, proxmox-time create and proxmox-backup have a fallback to /etc/localtime) - but that was just a very cursory glance at a grep '/etc/timezone' in my source-dir). Proxmox/Install.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 9cb88bc..fb23f7f 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -1299,7 +1299,6 @@ _EOD my $timezone = Proxmox::Install::Config::get_timezone(); unlink("$targetdir/etc/localtime"); symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime"); - file_write_all("$targetdir/etc/timezone", "$timezone\n"); unlink "$targetdir/etc/mailname"; $postfix_main_cf =~ s/__FQDN__/${hostname}.${domain}/; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel