From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 693771FF16F for ; Tue, 5 Aug 2025 23:35:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E188C1E0BA; Tue, 5 Aug 2025 23:36:55 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Tue, 5 Aug 2025 23:36:29 +0200 Message-Id: <20250805213629.1108359-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754429791452 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.066 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [configure-instance.sh, main.cf, install.pm] Subject: [pve-devel] [PATCH installer] install: set timezone, before configuring postfix X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" quite a few changes have been made to the postfix package in trixie. one of those is that `configure-instance.sh`, which handles chroot-creation is now called on service startup and e.g. with `postfix check`, which we run here[0]. this results in /etc/localtime being copied into the changeroot before we set it to the timezone configured by the installer, resulting in a warning upon rebooting (which would remain until you either `dpkg-reconfigure tzdata` or `touch /etc/localtime`. [0] https://salsa.debian.org/postfix-team/postfix-dev/-/commit/6a3cfe2931138898bea99b171c3731b17ee2fbae Signed-off-by: Stoiko Ivanov --- tested minimally with a current PBS iso - the postfix warnings after rebooting were gone for me. Proxmox/Install.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm index 706f7fd..9cb88bc 100644 --- a/Proxmox/Install.pm +++ b/Proxmox/Install.pm @@ -1295,6 +1295,12 @@ _EOD }, ); + # set timezone + my $timezone = Proxmox::Install::Config::get_timezone(); + unlink("$targetdir/etc/localtime"); + symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime"); + file_write_all("$targetdir/etc/timezone", "$timezone\n"); + unlink "$targetdir/etc/mailname"; $postfix_main_cf =~ s/__FQDN__/${hostname}.${domain}/; file_write_all("$targetdir/etc/postfix/main.cf", $postfix_main_cf); @@ -1309,12 +1315,6 @@ _EOD unlink "$targetdir/proxmox_install_mode"; my $country = Proxmox::Install::Config::get_country(); - my $timezone = Proxmox::Install::Config::get_timezone(); - - # set timezone - unlink("$targetdir/etc/localtime"); - symlink("/usr/share/zoneinfo/$timezone", "$targetdir/etc/localtime"); - file_write_all("$targetdir/etc/timezone", "$timezone\n"); # set apt mirror if (my $mirror = $iso_env->{locales}->{country}->{$country}->{mirror}) { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel