From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1CF731FF185 for ; Mon, 4 Aug 2025 20:38:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 18F3C38485; Mon, 4 Aug 2025 20:39:37 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 20:38:56 +0200 Message-Id: <20250804183856.773378-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754332724677 X-SPAM-LEVEL: Spam detection results: 0 AWL -2.436 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SOMETLD_ARE_BAD_TLD 5 .bar, .beauty, .buzz, .cam, .casa, .cfd, .club, .date, .guru, .link, .live, .monster, .online, .press, .pw, .quest, .rest, .sbs, .shop, .stream, .top, .trade, .wiki, .work, .xyz TLD abuse SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] 8 to 9 checks: warn if old udev-mac-pinning still present X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" We observed this in a host which has been updated through many major versions (at least since PVE 4). The 70-persistent-net.rules was used keeping the NICs with 'ethX' names. With the first reboot into trixie the NICs got their predictable names, and networking was broken (because the 'ethX' names are not present as altname the support for this does not help in this case) I could not reproduce the issue with a VM (there the 70-persistent-net.rules was still active and the NIC remained ethX), so it might be a race during early boot. In any case a warning makes sense here as it's becoming a very niche combination, and thus is likely to cause more issues in the future. Suggest to manually setup pinning as suggested in our documentation: https://pve.proxmox.com/pve-docs/pve-admin-guide.html#network_override_device_names seems sensible. Signed-off-by: Stoiko Ivanov --- PVE/CLI/pve8to9.pm | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 83f4a0c7..53ad3f10 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -2164,6 +2164,14 @@ sub check_misc { } } + my $udev_rule_file = "/etc/udev/rules.d/70-persistent-net.rules"; + if (-f $udev_rule_file) { + log_warn( + "Old udev rules file '$udev_rule_file' for NIC-pinning found - NICs are likely to be" + . " renamed with newer systemd version. Replace the file with a custom" + . " systemd.link file."); + } + log_info("Check node certificate's RSA key size"); my $certs = PVE::API2::Certificates->info({ node => $nodename }); my $certs_check = { -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel