From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 980231FF185 for ; Mon, 4 Aug 2025 18:23:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 17BBB36A9A; Mon, 4 Aug 2025 18:25:23 +0200 (CEST) From: Stefan Hanreich To: pbs-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 18:24:34 +0200 Message-ID: <20250804162448.607184-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.194 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} v5 00/10] proxmox-network-interface-pinning X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Introduce the proxmox-network-interface-pinning tool for PBS, written in Rust. I basically had to do the same changes to the network stack in PBS, that I already had to do for Proxmox VE: * use ip link for determining physical interfaces in the network configuration stack * move metric collection over to this new method as well In the process I moved the existing functions for querying 'ip link', that were already used by the firewall, to proxmox-network-api which seems like a better fit than proxmox-ve-config (which was only a temporary solution anyway). While I was at it, I also added support for reading altnames to proxmox-network-api, analogous to Proxmox VE. I also decided to move PBS over to the implementations contained in proxmox-network-api, but if this is considered too drastic a change so close to a release (I'm torn myself), then it should be trivial to revert those changes and implement / copy-paste everything to the respective projects instead. Updated backport branches are available on my staff repos. Changes from v4: * incorporate changes from @Wolfgang (thanks for the review!) * fix bug with one kind of VLAN devices not getting renamed (ensX.123) this required some serious refactoring in the rename_interfaces method (also removed Tested-by from some commits because of this). Changes from v3: (Thanks @Christian for testing!): * rebase on top of current master branches * include altname information in config returned by proxmox-network-api * display altnames of network interfaces in PBS UI * add documentation for proxmox-network-interface-pinning to PBS docs * add some documentation for the proxmox-network-interface-pinning source code * properly sort interfaces before generating an InterfaceMapping Changes from v2: * fix debian/control files Changes from v1: * remove Cargo.lock from proxmox-network-interface-pinning initial commit * change path for Proxmox VE pinning tool to /usr/libexec * install this tool to /usr/bin instead proxmox-backup depends on proxmox-network-api proxmox-firewall depends on proxmox-network-api proxmox-network-interface-pinning depends on proxmox-network-api proxmox-ve-rs: Stefan Hanreich (1): host: network: move to proxmox-network-api proxmox-ve-config/src/host/mod.rs | 1 - proxmox-ve-config/src/host/network.rs | 35 --------------------------- 2 files changed, 36 deletions(-) delete mode 100644 proxmox-ve-config/src/host/network.rs proxmox: Stefan Hanreich (3): pbs-api-types: use proxmox-network-api types proxmox-network-api: use ip link for querying interface information network-api: add rename_interfaces method Cargo.toml | 1 + pbs-api-types/src/lib.rs | 3 - pbs-api-types/src/network.rs | 345 ----------------------- pbs-api-types/src/traffic_control.rs | 6 +- proxmox-network-api/Cargo.toml | 2 + proxmox-network-api/debian/control | 8 +- proxmox-network-api/src/api_types.rs | 20 +- proxmox-network-api/src/config/helper.rs | 158 +++++++---- proxmox-network-api/src/config/mod.rs | 84 +++++- proxmox-network-api/src/config/parser.rs | 39 ++- 10 files changed, 235 insertions(+), 431 deletions(-) delete mode 100644 pbs-api-types/src/network.rs proxmox-backup: Stefan Hanreich (4): config: network: move to proxmox-network-api metric_collection: use ip link for determining the type of interfaces docs: add documentation for proxmox-network-interface-pinning ui: show altnames Cargo.toml | 5 + debian/control | 3 + docs/network-management.rst | 55 ++ pbs-config/src/lib.rs | 10 +- pbs-config/src/network/helper.rs | 223 ----- pbs-config/src/network/lexer.rs | 136 --- pbs-config/src/network/mod.rs | 687 --------------- pbs-config/src/network/parser.rs | 846 ------------------- src/api2/node/network.rs | 13 +- src/bin/proxmox-backup-api.rs | 3 +- src/bin/proxmox-backup-manager.rs | 1 + src/bin/proxmox-backup-proxy.rs | 1 + src/bin/proxmox_backup_manager/network.rs | 14 +- src/server/metric_collection/mod.rs | 87 +- src/server/metric_collection/pull_metrics.rs | 5 +- src/server/metric_collection/rrd.rs | 5 +- www/SystemConfiguration.js | 1 + 17 files changed, 170 insertions(+), 1925 deletions(-) delete mode 100644 pbs-config/src/network/helper.rs delete mode 100644 pbs-config/src/network/lexer.rs delete mode 100644 pbs-config/src/network/mod.rs delete mode 100644 pbs-config/src/network/parser.rs proxmox-firewall: Stefan Hanreich (1): firewall: config: use proxmox-network-api proxmox-firewall/Cargo.toml | 3 +- proxmox-firewall/src/config.rs | 33 ++++++--------------- proxmox-firewall/tests/integration_tests.rs | 8 ++--- 3 files changed, 14 insertions(+), 30 deletions(-) proxmox-network-interface-pinning: Stefan Hanreich (1): initial commit Summary over all repositories: 32 files changed, 419 insertions(+), 2422 deletions(-) -- Generated by git-murpp 0.8.0 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel