From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DE4AF1FF185 for ; Mon, 4 Aug 2025 16:20:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BB678337B4; Mon, 4 Aug 2025 16:22:18 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 16:20:53 +0200 Message-ID: <20250804142212.212744-1-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754317317299 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager 1/2] manager: support older versioning schema for ha group migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Prior to the Proxmox VE 8.x series, the pve-manager is versioned in the format of `M.m-p`. Versions prior to Proxmox VE 8.x are already EOL'd, but this change prevents any "Use of uninitialized value" log messages if one of the nodes is on a version with such a versioning scheme. Signed-off-by: Daniel Kral --- Missed that patch in the v2 for the follow-up for the ha-manager (but was included in the v1). Not really important (i.e. doesn't result in any fatal errors), but gets rid of a "use of unitialized value" warning from perl while running the tests/looking in the syslog in the rather unlikely (unsupported) case that one has the CRM node running PVE 9.* and another node still running 7.4... src/PVE/HA/Manager.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 884d098b..ba59f642 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -539,7 +539,7 @@ my $have_groups_been_migrated = sub { my $get_version_parts = sub { my ($node_version) = @_; - return $node_version =~ m/^(\d+)\.(\d+)\.(\d+)(?:~(\d+))?/; + return $node_version =~ m/^(\d+)\.(\d+)(?:\.|-)(\d+)(?:~(\d+))?/; }; my $has_node_min_version = sub { -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel