From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DBDB41FF185 for ; Mon, 4 Aug 2025 15:28:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D659C3199E; Mon, 4 Aug 2025 15:29:30 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 15:29:27 +0200 Message-Id: <20250804132928.1714525-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.39.5 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit 1/1] RRDChart: fix title lookup for object series X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" when we give a field(series) as an object instead of a string, we have to lookup the title from the object. The code was designed to do this, but accidentally always used the first entry in the 'fields' array to lookup the title if the field was not a plain string one. to fix this, simply check if the field is the one we're looking for Signed-off-by: Dominik Csapak --- this is necessary for the next patch to have correct tooltips src/panel/RRDChart.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js index c81e2e7..148015c 100644 --- a/src/panel/RRDChart.js +++ b/src/panel/RRDChart.js @@ -136,7 +136,7 @@ Ext.define('Proxmox.widget.RRDChart', { prefix = field.title[field.yField.indexOf(item.field)]; break; } - } else if (field.title) { + } else if (field.yField === item.field && field.title) { prefix = field.title; break; } -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel