From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1130F1FF185 for ; Mon, 4 Aug 2025 14:55:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A6F8A30DFA; Mon, 4 Aug 2025 14:56:36 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 14:55:46 +0200 Message-ID: <20250804125601.91944-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250804125601.91944-1-f.ebner@proxmox.com> References: <20250804125601.91944-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754312145824 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v2 2/2] pve8to9: rrd migration: mention storage RRD files for which automatic migration doesn't work X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The RRD migration tool currently has the limitation of not migrating RRD files for storages with a '.old' suffix. Mention the list of such storages below the RRD file list and migration command so that users can adapt before executing the migration command. Signed-off-by: Fiona Ebner --- New in v2. PVE/CLI/pve8to9.pm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm index 8c26ddbd..0109fade 100644 --- a/PVE/CLI/pve8to9.pm +++ b/PVE/CLI/pve8to9.pm @@ -1911,10 +1911,18 @@ sub check_rrd_migration { . join("\n\t ", $old_files->@*) . "\n\tPlease run the following command manually:\n" . "\t/usr/libexec/proxmox/proxmox-rrd-migration-tool --migrate\n"); + + my $cfg = PVE::Storage::config(); + my @unhandled_storages = grep { $_ =~ m|\.old$| } sort keys $cfg->{ids}->%*; + if (scalar(@unhandled_storages) > 0) { + my $storage_list_txt = join(", ", @unhandled_storages); + log_warn("RRD data for the following storages cannot be migrated" + . " automatically: $storage_list_txt\nRename the RRD files to a name without '.old'" + . " before migration and re-add that suffix after migration."); + } } else { log_pass("No old RRD metric files found, normally this means all have been migrated."); } - } else { log_info("Check space requirements for RRD migration..."); # multiplier values taken from KiB sizes of old and new RRD files -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel