From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1222E1FF185 for ; Mon, 4 Aug 2025 14:54:42 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BFA0F30DAB; Mon, 4 Aug 2025 14:56:07 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 4 Aug 2025 14:55:45 +0200 Message-ID: <20250804125601.91944-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250804125601.91944-1-f.ebner@proxmox.com> References: <20250804125601.91944-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754312145819 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.024 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH rrd-migration-tool v2 1/2] collect rrd files: only skip '.old' extension to better handle storage IDs containing a dot X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Storage IDs may contain a dot, which would make the tool ignore data for them. This does not fix the issue completely, the final corner case with storages being called called 'something.old' remains. A warning for storages called '.old' is added to the pve8to9 checker script. If enough people really run into this issue with such storages, the migration script will be improved further after the release of PVE 9. For now, use a straight-forward stop-gap measure to avoid the fallout from not handling any storage ID with a dot. Signed-off-by: Fiona Ebner --- Changes in v2: * Different approach as a less complicated stop-gap measure. src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main.rs b/src/main.rs index 9afd48b..e18551c 100644 --- a/src/main.rs +++ b/src/main.rs @@ -331,7 +331,7 @@ fn collect_rrd_files(location: &PathBuf) -> Result> { contents .filter(|f| f.is_ok()) .map(|f| f.unwrap().path()) - .filter(|f| f.is_file() && f.extension().is_none()) + .filter(|f| f.is_file() && f.extension().is_none_or(|ext| ext != "old")) .for_each(|file| { let path = CString::new(file.as_path().as_os_str().as_bytes()) .expect("Could not convert path to CString."); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel