From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 86AC01FF186 for ; Fri, 1 Aug 2025 18:21:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F5141E3FF; Fri, 1 Aug 2025 18:23:07 +0200 (CEST) From: Daniel Kral To: pve-devel@lists.proxmox.com Date: Fri, 1 Aug 2025 18:22:16 +0200 Message-ID: <20250801162230.296214-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250801162230.296214-1-d.kral@proxmox.com> References: <20250801162230.296214-1-d.kral@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754065339774 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.014 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH ha-manager v2 01/12] manager: fix ~revision version check for ha groups migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" For the minimum version of 9.0.0~16 to migrate ha groups, the version 9.0.0 would fail the test as 0 < 16 would be true. If the ~revision is not set for $version, then it is ordered after any minimum ~revision. Signed-off-by: Daniel Kral --- nothing changed since v1 src/PVE/HA/Manager.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 9d7cb73f..0be12061 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -548,10 +548,13 @@ my $has_node_min_version = sub { return 0 if $major == $min_major && $minor < $min_minor; return 0 if $major == $min_major && $minor == $min_minor && $patch < $min_patch; - $rev //= 0; $min_rev //= 0; return 0 - if $major == $min_major && $minor == $min_minor && $patch == $min_patch && $rev < $min_rev; + if $major == $min_major + && $minor == $min_minor + && $patch == $min_patch + && defined($rev) + && $rev < $min_rev; return 1; }; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel