From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id ED19F1FF165 for ; Thu, 31 Jul 2025 15:51:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D2A9F3C905; Thu, 31 Jul 2025 15:52:40 +0200 (CEST) From: Friedrich Weber To: pve-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 15:51:42 +0200 Message-ID: <20250731135147.138187-1-f.weber@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753969914170 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: RRD graphs: display PSI as percent X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Pressure stall information are actually in percent. This is not mentioned explicitly in the documentation, but e.g. in the kernel source [1]: > The percentage of wall clock time spent in those compound stall > states gives pressure numbers between 0 and 100 for each resource, > where the SOME percentage indicates workload slowdowns and the FULL > percentage indicates reduced CPU utilization: > > %SOME = time(SOME) / period > %FULL = time(FULL) / period Thus, also display them as percent in the GUI. This reverts commit 087af558631b96ba4fdc40548234e4fa5478b354. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/sched/psi.c?h=v6.16#n52 Signed-off-by: Friedrich Weber --- www/manager6/node/Summary.js | 3 +++ www/manager6/panel/GuestSummary.js | 3 +++ 2 files changed, 6 insertions(+) diff --git a/www/manager6/node/Summary.js b/www/manager6/node/Summary.js index c7abd276..9a3f84a4 100644 --- a/www/manager6/node/Summary.js +++ b/www/manager6/node/Summary.js @@ -204,6 +204,7 @@ Ext.define('PVE.node.Summary', { fields: ['pressurecpusome'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, { xtype: 'proxmoxRRDChart', @@ -212,6 +213,7 @@ Ext.define('PVE.node.Summary', { fields: ['pressureiosome', 'pressureiofull'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, { xtype: 'proxmoxRRDChart', @@ -220,6 +222,7 @@ Ext.define('PVE.node.Summary', { fields: ['pressurememorysome', 'pressurememoryfull'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, ], listeners: { diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js index 7780d731..f46006b4 100644 --- a/www/manager6/panel/GuestSummary.js +++ b/www/manager6/panel/GuestSummary.js @@ -142,6 +142,7 @@ Ext.define('PVE.guest.Summary', { fields: ['pressurecpusome', 'pressurecpufull'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, { xtype: 'proxmoxRRDChart', @@ -151,6 +152,7 @@ Ext.define('PVE.guest.Summary', { fields: ['pressureiosome', 'pressureiofull'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, { xtype: 'proxmoxRRDChart', @@ -160,6 +162,7 @@ Ext.define('PVE.guest.Summary', { fields: ['pressurememorysome', 'pressurememoryfull'], colors: ['#FFD13E', '#A61120'], store: rrdstore, + unit: 'percent', }, ); } -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel