From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 72EDF1FF165 for ; Thu, 31 Jul 2025 13:29:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F41E392BC; Thu, 31 Jul 2025 13:30:29 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 13:30:15 +0200 Message-ID: <20250731113015.148881-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753961414232 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Commit 691f530d ("network: optionally show alternative interface names") introduced the optional altnames field in the network edit grid. The chosen default configuration however does not even add the field, therefore setting it to hidden if no altnames data is present cannot work. Fix this by only hiding the field if it was actually configured to be shown in the first place. Fixes: 691f530d ("network: optionally show alternative interface names") Signed-off-by: Christian Ebner --- src/node/NetworkEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index cd9dc7c..601d788 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', { if (Ext.isArray(data.altnames)) { data.altnames = data.altnames.join('
'); } - } else { + } else if (me.showAltNames && !me.isCreate) { me.down('field[name=altnames]').setVisible(false); } me.setValues(data); -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 99DA31FF165 for ; Thu, 31 Jul 2025 13:29:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 777EE392E0; Thu, 31 Jul 2025 13:30:29 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 13:30:15 +0200 Message-ID: <20250731113015.148881-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753961414232 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Commit 691f530d ("network: optionally show alternative interface names") introduced the optional altnames field in the network edit grid. The chosen default configuration however does not even add the field, therefore setting it to hidden if no altnames data is present cannot work. Fix this by only hiding the field if it was actually configured to be shown in the first place. Fixes: 691f530d ("network: optionally show alternative interface names") Signed-off-by: Christian Ebner --- src/node/NetworkEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index cd9dc7c..601d788 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', { if (Ext.isArray(data.altnames)) { data.altnames = data.altnames.join('
'); } - } else { + } else if (me.showAltNames && !me.isCreate) { me.down('field[name=altnames]').setVisible(false); } me.setValues(data); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 1F5131FF165 for ; Thu, 31 Jul 2025 13:29:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EFA44392A6; Thu, 31 Jul 2025 13:30:28 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 13:30:15 +0200 Message-ID: <20250731113015.148881-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753961414232 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pmg-devel] [PATCH proxmox-widget-toolkit] network edit: fix hiding of altnames field if disabled by config X-BeenThere: pmg-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Mail Gateway development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pmg-devel-bounces@lists.proxmox.com Sender: "pmg-devel" Commit 691f530d ("network: optionally show alternative interface names") introduced the optional altnames field in the network edit grid. The chosen default configuration however does not even add the field, therefore setting it to hidden if no altnames data is present cannot work. Fix this by only hiding the field if it was actually configured to be shown in the first place. Fixes: 691f530d ("network: optionally show alternative interface names") Signed-off-by: Christian Ebner --- src/node/NetworkEdit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js index cd9dc7c..601d788 100644 --- a/src/node/NetworkEdit.js +++ b/src/node/NetworkEdit.js @@ -465,7 +465,7 @@ Ext.define('Proxmox.node.NetworkEdit', { if (Ext.isArray(data.altnames)) { data.altnames = data.altnames.join('
'); } - } else { + } else if (me.showAltNames && !me.isCreate) { me.down('field[name=altnames]').setVisible(false); } me.setValues(data); -- 2.47.2 _______________________________________________ pmg-devel mailing list pmg-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel