From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C1EC81FF165 for ; Thu, 31 Jul 2025 12:47:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 775F938589; Thu, 31 Jul 2025 12:48:30 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 31 Jul 2025 12:48:10 +0200 Message-ID: <20250731104814.99768-7-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250731104814.99768-1-c.ebner@proxmox.com> References: <20250731104814.99768-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753958894812 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v3 2/6] datastore: wrap bucket name, as in is now optional in the s3 client X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The bucket name is now optional so it is possible to also instantiate a client to perform operations without a bucket, e.g. listing of available buckets. Adapt the callsides accordingly. Signed-off-by: Christian Ebner --- changes since version 2: - rebased onto current master pbs-datastore/src/datastore.rs | 4 ++-- src/api2/admin/s3.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 57a90971a..5a22ffbcc 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -258,7 +258,7 @@ impl DataStore { let options = S3ClientOptions::from_config( config.config, config.secret_key, - bucket, + Some(bucket), self.name().to_owned(), ); let s3_client = S3Client::new(options)?; @@ -2433,7 +2433,7 @@ impl DataStore { let options = S3ClientOptions::from_config( client_config.config, client_config.secret_key, - bucket, + Some(bucket), datastore_config.name.to_owned(), ); let s3_client = S3Client::new(options).context("failed to create s3 client")?; diff --git a/src/api2/admin/s3.rs b/src/api2/admin/s3.rs index 1a0932945..90cc41ea6 100644 --- a/src/api2/admin/s3.rs +++ b/src/api2/admin/s3.rs @@ -48,7 +48,7 @@ pub async fn check( .context("config lookup failed")?; let options = - S3ClientOptions::from_config(config.config, config.secret_key, bucket, store_prefix); + S3ClientOptions::from_config(config.config, config.secret_key, Some(bucket), store_prefix); let test_object_key = S3ObjectKey::try_from(".s3-client-test").context("failed to generate s3 object key")?; -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel