From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 653F71FF183 for ; Wed, 30 Jul 2025 17:02:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 594F412836; Wed, 30 Jul 2025 17:04:01 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 17:03:15 +0200 Message-ID: <20250730150325.138087-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250730150325.138087-1-f.ebner@proxmox.com> References: <20250730150325.138087-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753887798168 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 1/3] image convert: avoid combining target image options and zeroinit filter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Would fail with an error > Block format 'qcow2' does not support the option 'zeroinit:driver' for a qcow2 target on a directory storage with 'snapshot-as-volume-chain'. Reported-by: Friedrich Weber Signed-off-by: Fiona Ebner --- src/PVE/QemuServer/QemuImage.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer/QemuImage.pm b/src/PVE/QemuServer/QemuImage.pm index bbfb4fd6..8fe75e92 100644 --- a/src/PVE/QemuServer/QemuImage.pm +++ b/src/PVE/QemuServer/QemuImage.pm @@ -109,11 +109,12 @@ sub convert { push @$cmd, '-f', $src_format; } + my $dst_uses_target_image_opts = $dst_is_iscsi || $dst_needs_discard_no_unref; + push @$cmd, '--target-image-opts' if $dst_uses_target_image_opts; + if ($dst_is_iscsi) { - push @$cmd, '--target-image-opts'; $dst_path = convert_iscsi_path($dst_path); } elsif ($dst_needs_discard_no_unref) { - push @$cmd, '--target-image-opts'; $dst_path = qcow2_target_image_opts($dst_path, 'discard-no-unref=true'); } else { push @$cmd, '-O', $dst_format; @@ -121,7 +122,7 @@ sub convert { push @$cmd, $src_path; - if (!$dst_is_iscsi && $opts->{'is-zero-initialized'}) { + if (!$dst_uses_target_image_opts && $opts->{'is-zero-initialized'}) { push @$cmd, "zeroinit:$dst_path"; } else { push @$cmd, $dst_path; -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel