From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 79E351FF183 for ; Wed, 30 Jul 2025 09:56:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8336E358A2; Wed, 30 Jul 2025 09:58:09 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Wed, 30 Jul 2025 09:57:42 +0200 Message-ID: <20250730075750.36014-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753862276095 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [restore.rs, datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup v2 0/8] remove objects from s3 backend on datastore destroy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This patch series makes sure the datastore contents are also removed from the s3 backend if the datastore is destroyed with the remove all data flag being set. The first 6 patches fix clippy warnings and refactor the s3 client from datastore config generation into a dedicated helper, since the last patch requires that as well and this would be the third ocurence thereof. Patch 0007 finally does the object store cleanup if the datastore is backed by s3 and the data should be removed. This simply clears all contents starting with the store prefix from the bucket. The last patch switches the label for the datastore destroy dialog, making it clear that data destruction includes s3 objects and locally cached data. Changes since version 1: - Added ui patch which was previously send as followup, including the suggested code cleanup changes. Christian Ebner (8): tree wide: fix useless borrow warnings client: backup writer: elide lifetime which can be auto inferred api: tape: fix clippy warning on map iteration datastore: fix clippy warning checking file extension datastore: fix clippy warning to use ? on option datastore: add helper to get s3 client from datastore config datastore: delete all objects on datastore destroy with remove data ui: switch datastore destroy label text on backend type pbs-client/src/backup_writer.rs | 4 +- pbs-config/src/datastore.rs | 2 +- pbs-datastore/src/datastore.rs | 64 +++++++++++++--- src/api2/config/datastore.rs | 119 +++++++++-------------------- src/api2/config/tape_backup_job.rs | 2 +- src/api2/tape/restore.rs | 2 +- www/datastore/OptionView.js | 24 +++++- 7 files changed, 120 insertions(+), 97 deletions(-) -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel