From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 74C7E1FF16B for ; Tue, 29 Jul 2025 19:16:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6240B1942D; Tue, 29 Jul 2025 19:17:26 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Tue, 29 Jul 2025 19:16:45 +0200 Message-ID: <20250729171649.708219-4-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250729171649.708219-1-s.hanreich@proxmox.com> References: <20250729171649.708219-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.195 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 2/2] network-interface-pinning: allow arbitrary names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" With the changes to physical interface detection in pve-common and pve-manager, it is now possible to use arbitrary names for physical interfaces in our network stack. This allows the removal of the existing, hardcoded, prefixes. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index 9bbc2929d..adc0acd52 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -370,14 +370,14 @@ __PACKAGE__->register_method({ description => 'Use a specific prefix for automatically choosing the pinned name.', type => 'string', - enum => ['nic', 'if'], + pattern => '^[a-zA-Z][a-zA-Z0-9-_]{0,7}$', default => 'nic', # just for the docs. optional => 1, }, 'target-name' => { description => 'Pin the interface to a specific name.', type => 'string', - pattern => '(?:nic|if)\d+', + format => 'pve-iface', optional => 1, requires => 'interface', }, -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel