From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AF6561FF16B for ; Tue, 29 Jul 2025 19:16:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 981B119586; Tue, 29 Jul 2025 19:17:27 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Tue, 29 Jul 2025 19:16:42 +0200 Message-ID: <20250729171649.708219-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.194 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH common/manager v2 0/3] arbitrary prefixes for pinning network interfaces X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" This patch series lifts the restriction for naming physical interfaces. Previously we relied on a regex (PHYSICAL_NIC_RE) for determining whether an interface was physical or not. This patch series changes that, by querying the kernel for the type of the interface and using that to determine whether an interface is a physical interface or not. This allows us to use arbitrary names for physical interfaces, which in turn allows proxmox-network-interface-pinning to use arbitrary prefixes / target-names when pinning network interfaces. The main change here is with pvestatd and metric collection, where we used the regex to determine the type of interface in PullMetric. I introduced a new key in the netdev hash that indicates the type of interface. Since my knowledge of this component is almost zero, I'm not sure if this is the proper approach. Maybe someone with more experience can chime in on possible issues / improvements. pve-manager depends on pve-common Changes from v1 to v2: * Cache ip link output * add dependency for pvenetcommit to pvestatd * use type only to distinguish between physical / virtual interfaces pve-common: Stefan Hanreich (1): inotify/interfaces: use ip link for detecting physical interfaces src/PVE/INotify.pm | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) pve-manager: Stefan Hanreich (2): pvestatd: pull metric: use ip link to detect physical interfaces network-interface-pinning: allow arbitrary names PVE/CLI/proxmox_network_interface_pinning.pm | 4 ++-- PVE/PullMetric.pm | 15 ++++++++++++--- PVE/Service/pvestatd.pm | 15 ++++++++++++++- services/pvestatd.service | 2 +- 4 files changed, 29 insertions(+), 7 deletions(-) Summary over all repositories: 5 files changed, 42 insertions(+), 19 deletions(-) -- Generated by git-murpp 0.8.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel