From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id BC1671FF16B for ; Tue, 29 Jul 2025 11:30:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7CACC476; Tue, 29 Jul 2025 11:32:01 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Tue, 29 Jul 2025 11:31:34 +0200 Message-ID: <20250729093139.316600-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753781508566 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 0/5] prefilter source list by encryption/verify state for sync jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Since the introduction of the `verified-only` and `encrypted-only` optional parameters for sync jobs, it is possible to exclude snapshot if their are not encrypted or verified from the sync. The current implementation, filtering the snapshots based on the manifest information only directly before syncing said snapshot, leads to the somewhat unexpected behaviour that in combination with the transfer-last parameter set, the transfer-last filtering is performed before the encryption/verificaton state filtering. This patch series improves the current behaviour by pre-filtering the snapshots already when generating the list of to be synced items. This allows to apply the transfer-last filtering only after the verified-only and encrypted-only filters, resulting in a more natural behaviour. Since this breaks with the current filter order, the breaking changes should be considered for version 4 only. Changes since version 1: - rebased onto current master proxmox-backup: Christian Ebner (5): api: admin: refactor generation of backup dir for snapshot listing api: factor out helper converting backup info to snapshot list item sync: source: list snapshot items instead of backup directories pull: refactor source snapshot list filtering logic sync: conditionally pre-filter source list by verified or encrypted state src/api2/admin/datastore.rs | 142 +++--------------------------------- src/server/pull.rs | 49 ++++++++----- src/server/push.rs | 44 +++++++---- src/server/sync.rs | 73 +++++++++++++----- src/tools/mod.rs | 129 ++++++++++++++++++++++++++++++++ 5 files changed, 252 insertions(+), 185 deletions(-) Summary over all repositories: 5 files changed, 252 insertions(+), 185 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel