From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 374631FF187 for ; Mon, 28 Jul 2025 14:40:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 617DC321E9; Mon, 28 Jul 2025 14:41:25 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jul 2025 14:40:06 +0200 Message-ID: <20250728124006.868999-8-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250728124006.868999-1-c.ebner@proxmox.com> References: <20250728124006.868999-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753706473949 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 7/7] datastore: delete all objects on datastore destroy with remove data X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" If the user requested to delete a datastore, including all of the data, also remove the objects from the s3 backend, if any. This is limited to deleting objects within the datastore path prefix within the bucket. Reported-by: Lukas Wagner Signed-off-by: Christian Ebner --- pbs-datastore/src/datastore.rs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index 3bc3aab0d..3e53a670b 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -2144,6 +2144,18 @@ impl DataStore { } } + if let (_backend, Some(s3_client)) = + Self::s3_client_and_backend_from_datastore_config(&datastore_config)? + { + // Delete all objects within the datastore prefix + let prefix = S3PathPrefix::Some(String::default()); + let delete_objects_error = + proxmox_async::runtime::block_on(s3_client.delete_objects_by_prefix(&prefix))?; + if delete_objects_error { + bail!("deleting objects failed"); + } + } + // chunks get removed last and only if the backups were successfully deleted if ok { remove(".chunks", &mut ok); -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel