From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A7A371FF187 for ; Mon, 28 Jul 2025 14:40:03 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 913CE3214B; Mon, 28 Jul 2025 14:41:24 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jul 2025 14:40:00 +0200 Message-ID: <20250728124006.868999-2-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250728124006.868999-1-c.ebner@proxmox.com> References: <20250728124006.868999-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753706472476 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/7] tree wide: fix useless borrow warnings X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Fix the useless borrows reported by `cargo clippy`. Signed-off-by: Christian Ebner --- pbs-config/src/datastore.rs | 2 +- pbs-datastore/src/datastore.rs | 6 +++--- src/api2/config/tape_backup_job.rs | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/pbs-config/src/datastore.rs b/pbs-config/src/datastore.rs index 5a5553dbc..4aecc0d3c 100644 --- a/pbs-config/src/datastore.rs +++ b/pbs-config/src/datastore.rs @@ -117,7 +117,7 @@ pub fn complete_calendar_event(_arg: &str, _param: &HashMap) -> /// Returns the datastore backend type from it's name pub fn datastore_backend_type(store: &str) -> Result { let (config, _) = config()?; - let store_config: DataStoreConfig = config.lookup("datastore", &store)?; + let store_config: DataStoreConfig = config.lookup("datastore", store)?; let backend_config: pbs_api_types::DatastoreBackendConfig = serde_json::from_value( pbs_api_types::DatastoreBackendConfig::API_SCHEMA diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs index e8be576f7..e3c0589a4 100644 --- a/pbs-datastore/src/datastore.rs +++ b/pbs-datastore/src/datastore.rs @@ -1780,7 +1780,7 @@ impl DataStore { delete_list: &mut Vec, gc_status: &mut GarbageCollectionStatus, ) -> Result { - let (chunk_path, digest) = match self.chunk_path_from_object_key(&object_key) { + let (chunk_path, digest) = match self.chunk_path_from_object_key(object_key) { Some(path) => path, None => return Ok(false), }; @@ -2218,7 +2218,7 @@ impl DataStore { .await? .context("failed to set maintenance mode")?; - let tmp_base = proxmox_sys::fs::make_tmp_dir(&self.base_path(), None) + let tmp_base = proxmox_sys::fs::make_tmp_dir(self.base_path(), None) .context("failed to create temporary content folder in {store_base}")?; if let Err(err) = async { @@ -2377,7 +2377,7 @@ impl DataStore { .with_context(|| format!("failed to refresh {:?}", self.base_path()))?; } - std::fs::remove_dir_all(&tmp_base) + std::fs::remove_dir_all(tmp_base) .with_context(|| format!("failed to cleanup temporary content in {tmp_base:?}"))?; Ok(()) diff --git a/src/api2/config/tape_backup_job.rs b/src/api2/config/tape_backup_job.rs index 786acde06..38dbe9747 100644 --- a/src/api2/config/tape_backup_job.rs +++ b/src/api2/config/tape_backup_job.rs @@ -185,7 +185,7 @@ pub fn update_tape_backup_job( digest: Option, ) -> Result<(), Error> { if let Some(store) = &update.setup.store { - assert_datastore_type(&store)?; + assert_datastore_type(store)?; } let _lock = pbs_config::tape_job::lock()?; -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel