From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A6AAD1FF187 for ; Mon, 28 Jul 2025 12:01:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 876181F457; Mon, 28 Jul 2025 12:02:43 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jul 2025 12:01:52 +0200 Message-ID: <20250728100154.556438-3-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250728100154.556438-1-c.ebner@proxmox.com> References: <20250728100154.556438-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753696921893 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox 2/2] s3 client: skip setting `If-None-Match` header for Backblaze B2 X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Backblaze B2 does not allow to set the `If-None-Match` http header for put requests, failing with an error instead of implementing or ignoring it. Skip setting the header (and therefore re-uploading the object) if the quirk configuration is set to backblaze. Reported-by: https://forum.proxmox.com/threads/168834/post-786278 Signed-off-by: Christian Ebner --- proxmox-s3-client/src/client.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs index bbe363da..bd7aff18 100644 --- a/proxmox-s3-client/src/client.rs +++ b/proxmox-s3-client/src/client.rs @@ -396,7 +396,12 @@ impl S3Client { .header(header::CONTENT_TYPE, "binary/octet"); if !replace { - request = request.header(header::IF_NONE_MATCH, "*"); + // Backblaze B2 does not implement this and fails with error if the header is set, + // see https://forum.proxmox.com/threads/168834/post-786278 + match self.options.quirks.as_deref() { + Some("backblaze") => (), + _ => request = request.header(header::IF_NONE_MATCH, "*"), + } } let request = request.body(object_data)?; -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel