From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id E69FF1FF187 for ; Mon, 28 Jul 2025 08:46:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C49681A48B; Mon, 28 Jul 2025 08:47:38 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jul 2025 08:46:44 +0200 Message-ID: <20250728064645.158414-10-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250728064645.158414-1-c.ebner@proxmox.com> References: <20250728064645.158414-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753685214698 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 5/6] bin: expose list buckets as proxmox-backup-manager s3 subcommand X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" Allows to list the buckets from the cli, mostly to be feature compatible with the rest of the api endpoints for s3. Signed-off-by: Christian Ebner --- src/bin/proxmox_backup_manager/s3.rs | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/bin/proxmox_backup_manager/s3.rs b/src/bin/proxmox_backup_manager/s3.rs index f660baf4a..a94371e09 100644 --- a/src/bin/proxmox_backup_manager/s3.rs +++ b/src/bin/proxmox_backup_manager/s3.rs @@ -1,5 +1,5 @@ use proxmox_router::{cli::*, ApiHandler, RpcEnvironment}; -use proxmox_s3_client::{S3_BUCKET_NAME_SCHEMA, S3_CLIENT_ID_SCHEMA}; +use proxmox_s3_client::{S3BucketListItem, S3_BUCKET_NAME_SCHEMA, S3_CLIENT_ID_SCHEMA}; use proxmox_schema::api; use proxmox_backup::api2; @@ -35,6 +35,23 @@ async fn check( Ok(Value::Null) } +#[api( + input: { + properties: { + "s3-endpoint-id": { + schema: S3_CLIENT_ID_SCHEMA, + }, + }, + }, +)] +/// List buckets accessible by the given S3 client configuration +async fn list_buckets( + s3_endpoint_id: String, + rpcenv: &mut dyn RpcEnvironment, +) -> Result, Error> { + api2::config::s3::list_buckets(s3_endpoint_id, rpcenv).await +} + #[api( input: { properties: { @@ -88,6 +105,12 @@ pub fn s3_commands() -> CommandLineInterface { CliCommand::new(&api2::config::s3::API_METHOD_DELETE_S3_CLIENT_CONFIG) .arg_param(&["id"]) .completion_cb("id", pbs_config::s3::complete_s3_client_id), + ) + .insert( + "list-buckets", + CliCommand::new(&API_METHOD_LIST_BUCKETS) + .arg_param(&["s3-endpoint-id"]) + .completion_cb("s3-endpoint-id", pbs_config::s3::complete_s3_client_id), ); let cmd_def = CliCommandMap::new() -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel