From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6FF591FF187 for ; Mon, 28 Jul 2025 08:45:48 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBFCC1A2E2; Mon, 28 Jul 2025 08:47:05 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Mon, 28 Jul 2025 08:46:35 +0200 Message-ID: <20250728064645.158414-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753685212525 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox{, -backup} 00/10] s3: implement list buckets and use bucket selector for datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" This patches aim to increase usability for the user by allowing to list accessible buckets during datastore creation. For this, the proxmox s3 client is extended by the list buckets method, fetching accessible buckets from the s3 api. This requires the client instantiation to be possible without the bucket name, making it therefore optional. Further, the regex for the config endpoint url must be restricted to have the bucket name template pattern always at the start of the template. With these changes, it is then possible to fetch the buckets given the required permissions to do so. On the proxmox backup server side, the api endpoints to fetch the bucket list are implemented as well as the corresponding cli command. Finally, the bucket name field in the datastore edit window is replaced by an s3 bucket selector, which loads the accessible bucket names via the api. proxmox: Christian Ebner (4): s3 client: restrict bucket template pattern to start of endpoint url s3 client: make bucket name optional in S3 client options s3 client: implement list buckets method s3 client: api types: add bucket list item type proxmox-s3-client/examples/s3_client.rs | 2 +- proxmox-s3-client/src/api_types.rs | 17 ++++++- proxmox-s3-client/src/client.rs | 39 +++++++++++++--- proxmox-s3-client/src/response_reader.rs | 58 ++++++++++++++++++++++++ 4 files changed, 108 insertions(+), 8 deletions(-) proxmox-backup: Christian Ebner (6): ui: fix formatting issues using proxmox-biome datastore: wrap bucket name, as in is now optional in the s3 client api: admin s3: make store prefix for check command optional api: config s3: add bucket list api endpoint bin: expose list buckets as proxmox-backup-manager s3 subcommand ui: replace bucket field by bucket selector pbs-datastore/src/datastore.rs | 2 +- src/api2/admin/s3.rs | 6 ++-- src/api2/config/datastore.rs | 4 +-- src/api2/config/s3.rs | 48 +++++++++++++++++++++++-- src/bin/proxmox_backup_manager/s3.rs | 28 +++++++++++++-- www/Makefile | 1 + www/Utils.js | 5 ++- www/form/S3BucketSelector.js | 52 ++++++++++++++++++++++++++++ www/window/DataStoreEdit.js | 27 +++++++++++---- 9 files changed, 155 insertions(+), 18 deletions(-) create mode 100644 www/form/S3BucketSelector.js Summary over all repositories: 13 files changed, 263 insertions(+), 26 deletions(-) -- Generated by git-murpp 0.8.1 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel