From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id DF5E11FF170 for ; Thu, 24 Jul 2025 14:42:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BF1B0399F9; Thu, 24 Jul 2025 14:43:26 +0200 (CEST) From: Christian Ebner To: pbs-devel@lists.proxmox.com Date: Thu, 24 Jul 2025 14:42:36 +0200 Message-ID: <20250724124236.838266-1-c.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753360971429 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup] api: return s3 client errors during datastore create with context X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" The error context might contain information directly pointing to the reason why the bucket cannot be reached during the datastore creation bucket access check. For example, the following text will be shown to the user in the error dialog: ``` failed to access bucket: client error (Connect): error connecting to https://test.s3.pve-c1.local:7480/ - dns error: failed to lookup address information: Name or service not known (400) ``` Suggested-by: Gabriel Goller Signed-off-by: Christian Ebner --- src/api2/config/datastore.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs index d24323152..b99f515ca 100644 --- a/src/api2/config/datastore.rs +++ b/src/api2/config/datastore.rs @@ -382,10 +382,13 @@ pub fn create_datastore( bucket, store_name.clone(), ); - let s3_client = S3Client::new(options).context("failed to create s3 client")?; + let s3_client = S3Client::new(options) + .context("failed to create s3 client") + .map_err(|err| format_err!("{err:#}"))?; // Fine to block since this runs in worker task proxmox_async::runtime::block_on(s3_client.head_bucket()) - .context("failed to access bucket")?; + .context("failed to access bucket") + .map_err(|err| format_err!("{err:#}"))?; } } -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel