From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 142DC1FF170 for ; Thu, 24 Jul 2025 11:34:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E54FC35CD1; Thu, 24 Jul 2025 11:35:34 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 24 Jul 2025 11:34:59 +0200 Message-Id: <20250724093459.76397-5-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250724093459.76397-1-s.hanreich@proxmox.com> References: <20250724093459.76397-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.195 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 4/4] network-interface-pinning: add if prefix to list of allowed prefixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" 'if' has been added as a possible prefix for physical nics in pve-common. Add it as a possible prefix for pinning network interfaces here as well. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index 357a78544..e2ad8c69f 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -359,7 +359,6 @@ __PACKAGE__->register_method({ parameters => { additionalProperties => 0, properties => { - # TODO: support a target name or prefix once pve-common supports generic physical ifaces interface => { description => 'Only pin a specific interface.', type => 'string', @@ -367,10 +366,17 @@ __PACKAGE__->register_method({ default => '', # just for the docs. optional => 1, }, + prefix => { + description => 'Only pin a specific interface.', + type => 'string', + enum => ['nic', 'if'], + default => 'nic', # just for the docs. + optional => 1, + }, 'target-name' => { description => 'Pin the interface to a specific name', type => 'string', - pattern => 'nic\d+', + pattern => '(?:nic|if)\d+', optional => 1, }, }, @@ -398,7 +404,7 @@ __PACKAGE__->register_method({ } my $code = sub { - my $prefix = 'nic'; # TODO: make flexible once pve-common supports that. + my $prefix = $params->{prefix} // 'nic'; my $ip_links = get_ip_links(); my $pinned = get_pinned(); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel