From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 55A4A1FF170 for ; Thu, 24 Jul 2025 11:34:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5FFCB35CF8; Thu, 24 Jul 2025 11:35:35 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Thu, 24 Jul 2025 11:34:57 +0200 Message-Id: <20250724093459.76397-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250724093459.76397-1-s.hanreich@proxmox.com> References: <20250724093459.76397-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.195 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 2/4] network-interface-pinning: improve printing mapping X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Instead of printing a separate line for each altname, the tool now only prints one line per physical interface. The primary name is used as an identifier and the altnames are printed additionally in parentheses (if they exist). Additionally, the output is now sorted by ifindex (just as the pin order), so interfaces should now be printed in ascending order. Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 24 ++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index 05b1de38a..9025cd835 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -414,8 +414,28 @@ __PACKAGE__->register_method({ exit 0; } - for my $old_name (sort keys $mapping->%*) { - print "Name for link '$old_name' will change to '$mapping->{$old_name}'\n"; + my $altnames = PVE::Network::altname_mapping($ip_links); + + my @sorted_links = sort { + my $a_name = $altnames->{$a} // $a; + my $b_name = $altnames->{$b} // $b; + + $ip_links->{$a_name}->{ifindex} <=> $ip_links->{$b_name}->{ifindex}; + } grep { + $ip_links->{$_} + } keys $mapping->%*; + + for my $old_name (@sorted_links) { + my $altname_string = ''; + + if (my $interface_altnames = $ip_links->{$old_name}->{altnames}) { + $altname_string = join(', ', $interface_altnames->@*); + } + + print "Name for link '$old_name' "; + print "($altname_string) " if $altname_string; + print "will change to '$mapping->{$old_name}'\n"; + } generate_link_files($ip_links, $mapping); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel