From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3ECD91FF170 for ; Thu, 24 Jul 2025 10:30:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3B0F233BAD; Thu, 24 Jul 2025 10:32:12 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 24 Jul 2025 10:31:58 +0200 Message-ID: <20250724083205.15646-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753345927010 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.026 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v3 manager] api: create pool: force first character to be a letter for new pools X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Currently, the first character can also be a digit, '.', '-', or '_'. Almost all other configuration IDs in Proxmox VE require starting with a letter, so force this for new pool names too. A pool with ID '0' can be added, but not parsed, because it will evaluate to false in PVE/AccessControl.pm's parse_user_config(): > if (!verify_poolname($pool, 1)) { > warn "user config - ignore pool '$pool' - invalid characters in pool name\n"; > next; > } It's likely that it would cause other issues as well if properly handled there. Signed-off-by: Fiona Ebner --- Changes in v3: * rebase on master, make tidy PVE/API2/Pool.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/PVE/API2/Pool.pm b/PVE/API2/Pool.pm index 138b50a6..63aff5bb 100644 --- a/PVE/API2/Pool.pm +++ b/PVE/API2/Pool.pm @@ -189,10 +189,13 @@ __PACKAGE__->register_method({ my $pool = $param->{poolid}; die "pool '$pool' already exists\n" if $usercfg->{pools}->{$pool}; - if ($pool =~ m!^(.*)/[^/]+$!) { - my $parent = $1; + if ($pool =~ m!^(.*)/([^/]+)$!) { + my ($parent, $leaf) = ($1, $2); die "parent '$parent' of pool '$pool' does not exist\n" if !defined($usercfg->{pools}->{$parent}); + die "pool name must start with a letter\n" if $leaf !~ m!^[A-Za-z]!; + } else { + die "pool name must start with a letter\n" if $pool !~ m!^[A-Za-z]!; } $usercfg->{pools}->{$pool} = { -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel