From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 23C411FF17C for ; Wed, 23 Jul 2025 17:14:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8662016DE3; Wed, 23 Jul 2025 17:15:28 +0200 (CEST) From: Shannon Sterz To: pbs-devel@lists.proxmox.com Date: Wed, 23 Jul 2025 17:14:00 +0200 Message-ID: <20250723151356.264229-9-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250723151356.264229-3-s.sterz@proxmox.com> References: <20250723151356.264229-3-s.sterz@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753283685323 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup v2 2/3] ui: opt into the new HttpOnly ticket authentication flow X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" this should add additional protections for cookie stealing and xss attacks. it also makes it harder to overwrite the cookie from malicious subdomains. Signed-off-by: Shannon Sterz Tested-by: Mira Limbeck Tested-by: Maximiliano Sandoval --- changes since v1: - minor lint fix-up where a trailing "," was missing in the second proxmox-backup patch - consistently use "HttpOnly" instead of switching between "http only", "http-only" and "HttpOnly" in comments and user facing documentation, thanks @ Mira Limbeck www/Application.js | 12 +++++++++++- www/LoginView.js | 4 +++- www/MainView.js | 1 + www/Utils.js | 6 ++++++ 4 files changed, 21 insertions(+), 2 deletions(-) diff --git a/www/Application.js b/www/Application.js index 9e223522..e82ccdd0 100644 --- a/www/Application.js +++ b/www/Application.js @@ -18,7 +18,17 @@ Ext.define('PBS.Application', { logout: function () { var me = this; Proxmox.Utils.authClear(); - me.changeView('loginview', true); + Proxmox.Utils.API2Request({ + url: '/api2/extjs/access/ticket', + method: 'DELETE', + success: function () { + me.changeView('loginview', true); + }, + failure: function ({ response }) { + // logout failed + console.error('could not log out', response); + }, + }); }, changeView: function (view, skipCheck) { diff --git a/www/LoginView.js b/www/LoginView.js index a7764e5b..9c1ac38a 100644 --- a/www/LoginView.js +++ b/www/LoginView.js @@ -86,6 +86,8 @@ Ext.define('PBS.LoginView', { } sp.set(saveunField.getStateId(), saveunField.getValue()); + creds['http-only'] = true; + try { let resp = await Proxmox.Async.api2({ url: '/api2/extjs/access/ticket', @@ -94,7 +96,7 @@ Ext.define('PBS.LoginView', { }); let data = resp.result.data; - if (data.ticket.startsWith('PBS:!tfa!')) { + if (data.ticket?.startsWith('PBS:!tfa!')) { data = await me.performTFAChallenge(data); } diff --git a/www/MainView.js b/www/MainView.js index b5ae3605..70adfbce 100644 --- a/www/MainView.js +++ b/www/MainView.js @@ -172,6 +172,7 @@ Ext.define('PBS.MainView', { params: { username: Proxmox.UserName, password: ticket, + 'http-only': true, }, url: '/api2/json/access/ticket', method: 'POST', diff --git a/www/Utils.js b/www/Utils.js index 7fcf60e6..ccdae522 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -8,6 +8,12 @@ Ext.define('PBS.Utils', { missingText: gettext('missing'), updateLoginData: function (data) { + if (data['ticket-info']) { + // we received a HttpOnly ticket response, the actual cookie is handled by the browser. + // set the ticket field to use the information from `ticket-info` + data.ticket = data['ticket-info']; + } + Proxmox.Utils.setAuthData(data); }, -- 2.47.2 _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel