From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8C41E1FF17C for ; Wed, 23 Jul 2025 13:57:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EC12CFFA1; Wed, 23 Jul 2025 13:58:46 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 23 Jul 2025 13:57:38 +0200 Message-ID: <20250723115809.96282-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250723115809.96282-1-f.ebner@proxmox.com> References: <20250723115809.96282-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753271882049 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager v3 3/6] vzdump: use verbose size suffix when logging archive file size X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The single-letter suffixes are ambiguous and especially in the context of disks, the powers of ten are usually used. Use exact suffixes instead when logging the archive file size. Signed-off-by: Fiona Ebner --- PVE/VZDump.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index cf71a9fa..d7cce65c 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -240,19 +240,19 @@ sub format_size { my $kb = $size / 1024; if ($kb < 1024) { - return int($kb) . "KB"; + return int($kb) . "KiB"; } my $mb = $size / (1024 * 1024); if ($mb < 1024) { - return int($mb) . "MB"; + return int($mb) . "MiB"; } my $gb = $mb / 1024; if ($gb < 1024) { - return sprintf("%.2fGB", $gb); + return sprintf("%.2fGiB", $gb); } my $tb = $gb / 1024; - return sprintf("%.2fTB", $tb); + return sprintf("%.2fTiB", $tb); } sub format_time { -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel