From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 123A61FF17C for ; Wed, 23 Jul 2025 13:57:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2756FF4B; Wed, 23 Jul 2025 13:58:45 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Wed, 23 Jul 2025 13:57:37 +0200 Message-ID: <20250723115809.96282-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250723115809.96282-1-f.ebner@proxmox.com> References: <20250723115809.96282-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753271882044 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [jsonschema.pm] Subject: [pve-devel] [PATCH common v3 2/6] fix #3900: schema: prefer sizes with verbose suffixes {K, M, G, T}iB X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The single-letter suffixes are ambiguous and especially in the context of disks, the powers of ten are usually used. Proxmox VE uses multiples of 1024 however. By adapting format_size() to use the verbose suffixes all newly written or re-written sizes will use the more verbose/explicit suffix. Signed-off-by: Fiona Ebner --- src/PVE/JSONSchema.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/PVE/JSONSchema.pm b/src/PVE/JSONSchema.pm index e7c366f..e1f6334 100644 --- a/src/PVE/JSONSchema.pm +++ b/src/PVE/JSONSchema.pm @@ -1015,15 +1015,15 @@ sub format_size { return $size if $kb * 1024 != $size; my $mb = int($kb / 1024); - return "${kb}K" if $mb * 1024 != $kb; + return "${kb}KiB" if $mb * 1024 != $kb; my $gb = int($mb / 1024); - return "${mb}M" if $gb * 1024 != $mb; + return "${mb}MiB" if $gb * 1024 != $mb; my $tb = int($gb / 1024); - return "${gb}G" if $tb * 1024 != $gb; + return "${gb}GiB" if $tb * 1024 != $gb; - return "${tb}T"; + return "${tb}TiB"; } sub parse_boolean { -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel