From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 45EC21FF185 for ; Mon, 21 Jul 2025 14:11:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C3D58D12F; Mon, 21 Jul 2025 14:12:04 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Mon, 21 Jul 2025 14:10:45 +0200 Message-ID: <20250721121124.77526-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753099880858 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES storage/qemu-server 0/9] storage configuration-dependent format info X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The LVM plugin can only use qcow2 format when the 'snapshot-as-volume-chain' configuration option is set. The format information is currently only recorded statically in the plugin data. This causes issues, for example, restoring a guest volume that uses qcow2 as a format hint on an LVM storage without the option set will fail, because the plugin data indicates that qcow2 is supported. Introduce a dedicated method, so that plugins can indicate what actually is supported according to the storage configuration. In case the 'snapshot-as-volume-chain' option is set for the LVM storage, qcow2 is even preferred and thus declared the default format. As a second step, a dedicated resolve_format_hint() helper is introduced. That second part requires a dependency and a breaks between qemu-server and pve-storage. storage: Fiona Ebner (6): api change log: improve style consistency a bit plugin: add get_formats() method and use it instead of default_format() lvm plugin: implement get_formats() method api: status: rely on get_formats() method for determining format-related info introduce resolve_format_hint() helper default format helper: only return default format ApiChangeLog | 22 +++++++++---- src/PVE/API2/Storage/Status.pm | 6 ---- src/PVE/Storage.pm | 32 ++++++++++++------ src/PVE/Storage/LVMPlugin.pm | 10 ++++++ src/PVE/Storage/Plugin.pm | 59 +++++++++++++++++++++++----------- 5 files changed, 88 insertions(+), 41 deletions(-) qemu-server: Fiona Ebner (3): make tidy resolve destination disk format helper: drop unused variable use storage layer's resolve_format_hint() helper where appropriate src/PVE/API2/Qemu/HMPPerms.pm | 2 +- src/PVE/QemuServer.pm | 29 ++++++++--------------------- src/PVE/VZDump/QemuServer.pm | 5 ++--- 3 files changed, 11 insertions(+), 25 deletions(-) Summary over all repositories: 8 files changed, 99 insertions(+), 66 deletions(-) -- Generated by git-murpp 0.5.0 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel