From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id AE6CE1FF17A for ; Fri, 18 Jul 2025 18:25:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A8BAA35703; Fri, 18 Jul 2025 18:26:47 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:26:26 +0200 Message-Id: <20250718162638.444705-7-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718162638.444705-1-s.hanreich@proxmox.com> References: <20250718162638.444705-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.206 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 04/16] firewall on-boot commit: report errors if rename fails X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" From: Thomas Lamprecht Signed-off-by: Thomas Lamprecht Signed-off-by: Stefan Hanreich --- bin/pve-firewall-commit | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bin/pve-firewall-commit b/bin/pve-firewall-commit index ebcf9812d..e0d4eb410 100644 --- a/bin/pve-firewall-commit +++ b/bin/pve-firewall-commit @@ -9,6 +9,9 @@ my $local_node = PVE::INotify::nodename(); my $current_fw_config_file = "/etc/pve/nodes/$local_node/host.fw"; my $new_fw_config_file = "/etc/pve/nodes/$local_node/host.fw.new"; -rename($new_fw_config_file, $current_fw_config_file) if -e $new_fw_config_file; +if (-e $new_fw_config_file) { + rename($new_fw_config_file, $current_fw_config_file) + or die "failed to commit new local node firewall config '$new_fw_config_file' - $!\n"; +} exit 0; -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel