From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0CA661FF17A for ; Fri, 18 Jul 2025 18:25:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E33EC3544C; Fri, 18 Jul 2025 18:26:42 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:26:22 +0200 Message-Id: <20250718162638.444705-3-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718162638.444705-1-s.hanreich@proxmox.com> References: <20250718162638.444705-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.207 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, network.pm] Subject: [pve-devel] [PATCH pve-common v2 2/2] network: add nic prefix to physical nic regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" With the introduction of pveeth, users can now pin their NICs with prefix nicX. In order for our stack to correctly pick up the pinned interfaces, we need to add this prefix to the regex used for detecting physical interfaces. In the future we should abandon this method of detecting physical interfaces altogether, either by using `ip link` or talking Netlink directly. For now, we add this as a stop-gap so the pveeth tool proof-of-concept works. Signed-off-by: Stefan Hanreich Link: https://lore.proxmox.com/20250709194526.560709-3-s.hanreich@proxmox.com --- src/PVE/Network.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network.pm b/src/PVE/Network.pm index ce87b93..b305105 100644 --- a/src/PVE/Network.pm +++ b/src/PVE/Network.pm @@ -17,7 +17,7 @@ use Socket qw(NI_NUMERICHOST NI_NUMERICSERV); # host network related utility functions -our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+)/; +our $PHYSICAL_NIC_RE = qr/(?:eth\d+|en[^:.]+|ib[^:.]+|nic\d+)/; our $ipv4_reverse_mask = [ '0.0.0.0', -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel