From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 23C331FF17A for ; Fri, 18 Jul 2025 18:27:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 259F035CFB; Fri, 18 Jul 2025 18:27:16 +0200 (CEST) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 18:26:30 +0200 Message-Id: <20250718162638.444705-11-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250718162638.444705-1-s.hanreich@proxmox.com> References: <20250718162638.444705-1-s.hanreich@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.202 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods RDNS_NONE 0.793 Delivered to internal network by a host with no rDNS SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-manager v2 08/16] nic pinning: improve some informational and error output wording/formatting X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Thomas Lamprecht Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" From: Thomas Lamprecht Mainly add a trailing \n to die invocations to avoid getting a ugly "at line XY" in the output. Signed-off-by: Thomas Lamprecht Signed-off-by: Stefan Hanreich --- PVE/CLI/proxmox_network_interface_pinning.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/PVE/CLI/proxmox_network_interface_pinning.pm b/PVE/CLI/proxmox_network_interface_pinning.pm index 4b7f72404..ea98ccb5e 100644 --- a/PVE/CLI/proxmox_network_interface_pinning.pm +++ b/PVE/CLI/proxmox_network_interface_pinning.pm @@ -145,10 +145,10 @@ my sub parse_link_file { $section = $1; $data->{$section} = {}; } elsif ($line =~ m/^([a-zA-Z]+)=(.+)$/) { - die "key-value pair before section" if !$section; + die "key-value pair before section at line: $line\n" if !$section; $data->{$section}->{$1} = $2; } else { - die "unrecognized line"; + die "unrecognized line: $line\n"; } } @@ -381,18 +381,18 @@ __PACKAGE__->register_method({ ); for my $old_name (sort keys $mapping->%*) { - print "Renaming link '$old_name' to '$mapping->{$old_name}'\n"; + print "Name for link '$old_name' will change to '$mapping->{$old_name}'\n"; } generate_link_files($ip_links, $mapping); - print "Succesfully generated .link files\n"; + print "Successfully generated .link files in '/usr/local/lib/systemd/network/'\n"; update_host_fw_config($mapping); update_etc_network_interfaces($mapping, $existing_pins); update_sdn_controllers($mapping); - print "Successfully updated Proxmox VE configuration files\n"; - print "Please reboot to apply the changes to your configuration\n"; + print "Successfully updated Proxmox VE configuration files.\n"; + print "\nPlease reboot to apply the changes to your configuration\n\n"; }; PVE::Tools::lock_file($PVEETH_LOCK, 10, $code); -- 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel