From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 31E4A1FF17A for ; Fri, 18 Jul 2025 17:03:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B20D33655; Fri, 18 Jul 2025 17:04:36 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Fri, 18 Jul 2025 17:03:51 +0200 Message-ID: <20250718150426.166320-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 MIME-Version: 1.0 X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1752851068935 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [content.pm] Subject: [pve-devel] [PATCH storage] close #5492: api: content: allow listing volumes with Datastore.Audit privilege X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The check_volume_access() method is for checking read access to a volume. Users should be able to list the images, e.g. to check backup health via monitoring like reported in #5492 comment 3, with just an audit privilege. Signed-off-by: Fiona Ebner --- src/PVE/API2/Storage/Content.pm | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/PVE/API2/Storage/Content.pm b/src/PVE/API2/Storage/Content.pm index 1fe7303..c1f9a1f 100644 --- a/src/PVE/API2/Storage/Content.pm +++ b/src/PVE/API2/Storage/Content.pm @@ -154,12 +154,6 @@ __PACKAGE__->register_method({ my $res = []; foreach my $item (@$vollist) { - eval { - PVE::Storage::check_volume_access( - $rpcenv, $authuser, $cfg, undef, $item->{volid}, - ); - }; - next if $@; $item->{vmid} = int($item->{vmid}) if defined($item->{vmid}); $item->{size} = int($item->{size}) if defined($item->{size}); $item->{used} = int($item->{used}) if defined($item->{used}); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel