From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8863B1FF165 for ; Thu, 17 Jul 2025 15:36:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 668D03AE93; Thu, 17 Jul 2025 15:37:18 +0200 (CEST) From: Fiona Ebner To: pve-devel@lists.proxmox.com Date: Thu, 17 Jul 2025 15:36:50 +0200 Message-ID: <20250717133711.84715-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250717133711.84715-1-f.ebner@proxmox.com> References: <20250717133711.84715-1-f.ebner@proxmox.com> MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [accesscontrol.pm, perm-test1.pl] Subject: [pve-devel] [PATCH access-control 2/9] privileges: drop VM.Monitor X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" The name VM.Monitor is ambiguous and makes it hard to guess what the privilege is for. The privilege was used for two things: 1. QEMU guest agent operations, for which dedicated privileges were introduced, see commit "add VM.GuestAgent privileges". 2. Access to the QEMU HMP monitor, where only the 'info' and 'help' commands were usable without an additional Sys.Modify privilege. Access to the monitor will be guarded with Sys.Audit. Signed-off-by: Fiona Ebner --- src/PVE/AccessControl.pm | 1 - src/test/perm-test1.pl | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/PVE/AccessControl.pm b/src/PVE/AccessControl.pm index 3e12850..e48e647 100644 --- a/src/PVE/AccessControl.pm +++ b/src/PVE/AccessControl.pm @@ -1061,7 +1061,6 @@ my $privgroups = { 'VM.Clone', 'VM.GuestAgent.Unrestricted', 'VM.Migrate', - 'VM.Monitor', 'VM.Snapshot', 'VM.Snapshot.Rollback', ], diff --git a/src/test/perm-test1.pl b/src/test/perm-test1.pl index bf01ac6..50b46e2 100755 --- a/src/test/perm-test1.pl +++ b/src/test/perm-test1.pl @@ -66,8 +66,8 @@ check_permission( . 'VM.Allocate,VM.Audit,VM.Backup,VM.Clone,VM.Config.CDROM,VM.Config.CPU,VM.Config.Cloudinit,' . 'VM.Config.Disk,VM.Config.HWType,VM.Config.Memory,VM.Config.Network,VM.Config.Options,' . 'VM.Console,VM.GuestAgent.Audit,VM.GuestAgent.FileRead,VM.GuestAgent.FileSystemMgmt,' - . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.Monitor,VM.PowerMgmt,' - . 'VM.Snapshot,VM.Snapshot.Rollback', + . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.PowerMgmt,VM.Snapshot,' + . 'VM.Snapshot.Rollback', ); # Administrator -> Permissions.Modify! check_permission( @@ -86,8 +86,8 @@ check_permission( . 'VM.Allocate,VM.Audit,VM.Backup,VM.Clone,VM.Config.CDROM,VM.Config.CPU,VM.Config.Cloudinit,' . 'VM.Config.Disk,VM.Config.HWType,VM.Config.Memory,VM.Config.Network,VM.Config.Options,' . 'VM.Console,VM.GuestAgent.Audit,VM.GuestAgent.FileRead,VM.GuestAgent.FileSystemMgmt,' - . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.Monitor,VM.PowerMgmt,' - . 'VM.Snapshot,VM.Snapshot.Rollback', + . 'VM.GuestAgent.FileWrite,VM.GuestAgent.Unrestricted,VM.Migrate,VM.PowerMgmt,VM.Snapshot,' + . 'VM.Snapshot.Rollback', ); check_roles('max@pve', '/vms/200', 'storage_manager'); -- 2.47.2 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel